Bug 162633 - Update style guide for #pragma once
Summary: Update style guide for #pragma once
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-27 14:16 PDT by Joseph Pecoraro
Modified: 2016-09-27 21:37 PDT (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.42 KB, patch)
2016-09-27 14:17 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (2.42 KB, patch)
2016-09-27 16:22 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-27 14:16:28 PDT
Update style guide for #pragma once
Comment 1 Joseph Pecoraro 2016-09-27 14:17:43 PDT
Created attachment 290006 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2016-09-27 14:18:42 PDT
As discussed on webkit-dev:
https://lists.webkit.org/pipermail/webkit-dev/2016-March/thread.html#28058
Comment 3 mitz 2016-09-27 16:10:10 PDT
Comment on attachment 290006 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=290006&action=review

> Websites/webkit.org/code-style.md:698
> +[](#names-header-guards) Use `#pragma once` instead of `#define` and `#ifdef` for header guards.

Should the anchor name change to something else? Does the style-checking script reference this anchor?
Comment 4 Joseph Pecoraro 2016-09-27 16:19:43 PDT
Comment on attachment 290006 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=290006&action=review

>> Websites/webkit.org/code-style.md:698
>> +[](#names-header-guards) Use `#pragma once` instead of `#define` and `#ifdef` for header guards.
> 
> Should the anchor name change to something else? Does the style-checking script reference this anchor?

We can change this, there are no references in WebKit to this anchor.
Comment 5 Joseph Pecoraro 2016-09-27 16:22:52 PDT
Created attachment 290019 [details]
[PATCH] Proposed Fix
Comment 6 WebKit Commit Bot 2016-09-27 21:37:48 PDT
Comment on attachment 290019 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 290019

Committed r206495: <http://trac.webkit.org/changeset/206495>
Comment 7 WebKit Commit Bot 2016-09-27 21:37:52 PDT
All reviewed patches have been landed.  Closing bug.