To ease landing of MSE patches, it's advisable to disable Media Source and Encrypted Media (V1 & V2) by default on WebKitGTK+ and EFL.
Created attachment 289964 [details]
Comment on attachment 289964 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=289964&action=review
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA_V2 PUBLIC ON)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA_V2 PUBLIC OFF)
After talking to Žan we think it is better to leave this as it is cause we will land everything together and it is unnecessary.
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE PUBLIC ON)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE PUBLIC OFF)
> + * Source/cmake/OptionsEfl.cmake:
Created attachment 289971 [details]
Comment on attachment 289971 [details]
ENABLE_ENCRYPTED_MEDIA has been removed as part of bug #161010. This patch needs rework.
Created attachment 290204 [details]
Comment on attachment 290204 [details]
Wait until all the patches in 157314 are ready.
Created attachment 291753 [details]
Created attachment 292885 [details]
Comment on attachment 292885 [details]
Clearing flags on attachment: 292885
Committed r207872: <http://trac.webkit.org/changeset/207872>
All reviewed patches have been landed. Closing bug.
So these features are already disabled in WebKitFeatures.cmake. All this did is make the options public, which isn't right as they are still experimental features and not ready to be advertised as supported options. Hence I'm going to roll this out. I think no further changes are required here, I just don't want the options to be public until they're really ready. :)
Committed r208654: <http://trac.webkit.org/changeset/208654>