Bug 162621 - Related videos on YouTube (and YouTube playlists) cause media controls to disappear
Summary: Related videos on YouTube (and YouTube playlists) cause media controls to dis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-27 09:41 PDT by Wenson Hsieh
Modified: 2016-09-27 12:42 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.02 KB, patch)
2016-09-27 09:55 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch for landing (7.82 KB, patch)
2016-09-27 12:09 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2016-09-27 09:41:35 PDT
Related videos on YouTube (and YouTube playlists) cause media controls to disappear
Comment 1 Wenson Hsieh 2016-09-27 09:42:05 PDT
<rdar://problem/28484193>
Comment 2 Wenson Hsieh 2016-09-27 09:55:13 PDT
Created attachment 289960 [details]
Patch
Comment 3 Jer Noble 2016-09-27 10:28:18 PDT
Comment on attachment 289960 [details]
Patch

Just an observation: the heuristics for now playing and the controls manager are diverging enough that we should consider splitting them up (rather than leaving them both in MediaElementSession::canShowControlsManager().
Comment 4 Wenson Hsieh 2016-09-27 10:57:36 PDT
(In reply to comment #3)
> Comment on attachment 289960 [details]
> Patch
> 
> Just an observation: the heuristics for now playing and the controls manager
> are diverging enough that we should consider splitting them up (rather than
> leaving them both in MediaElementSession::canShowControlsManager().

I agree! We should have a canShowNowPlaying() that we can consult. I think currently the two codepaths are in an awkward state where about half of the checks are still common to both purposes, but I think splitting them out will give us more flexibility in the future, and we should refactor this soon.
Comment 5 Wenson Hsieh 2016-09-27 12:09:22 PDT
Created attachment 289994 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2016-09-27 12:42:05 PDT
Comment on attachment 289994 [details]
Patch for landing

Clearing flags on attachment: 289994

Committed r206454: <http://trac.webkit.org/changeset/206454>
Comment 7 WebKit Commit Bot 2016-09-27 12:42:09 PDT
All reviewed patches have been landed.  Closing bug.