Bug 162620 - It should be possible to dispatch events on documents that do not have a browsing context
Summary: It should be possible to dispatch events on documents that do not have a brow...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks: 26147
  Show dependency treegraph
 
Reported: 2016-09-27 09:22 PDT by Chris Dumez
Modified: 2016-09-27 15:03 PDT (History)
8 users (show)

See Also:


Attachments
WIP patch (8.12 KB, patch)
2016-09-27 09:24 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP patch (10.57 KB, patch)
2016-09-27 09:54 PDT, Chris Dumez
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-yosemite (1.16 MB, application/zip)
2016-09-27 10:45 PDT, Build Bot
no flags Details
WIP patch (9.65 KB, patch)
2016-09-27 10:51 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP patch (9.64 KB, patch)
2016-09-27 11:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-yosemite (1.12 MB, application/zip)
2016-09-27 12:00 PDT, Build Bot
no flags Details
Patch (14.01 KB, patch)
2016-09-27 12:19 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-09-27 09:22:34 PDT
It should be possible to dispatch events on documents that do not have a browsing context (e.g. Documents created using DOMImplementation.createHTMLDocument()). Gecko and Blink both allow this but WebKit does not.
Comment 1 Chris Dumez 2016-09-27 09:24:04 PDT
Created attachment 289953 [details]
WIP patch
Comment 2 WebKit Commit Bot 2016-09-27 09:27:09 PDT
Attachment 289953 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:4123:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2016-09-27 09:54:56 PDT
Created attachment 289959 [details]
WIP patch
Comment 4 Build Bot 2016-09-27 10:45:30 PDT
Comment on attachment 289959 [details]
WIP patch

Attachment 289959 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2155594

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-09-27 10:45:33 PDT
Created attachment 289973 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Chris Dumez 2016-09-27 10:51:17 PDT
Created attachment 289978 [details]
WIP patch
Comment 7 Chris Dumez 2016-09-27 11:01:35 PDT
Created attachment 289982 [details]
WIP patch
Comment 8 Alexey Proskuryakov 2016-09-27 11:29:42 PDT
Duplicate of bug 26147?
Comment 9 Build Bot 2016-09-27 12:00:14 PDT
Comment on attachment 289982 [details]
WIP patch

Attachment 289982 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2156208

Number of test failures exceeded the failure limit.
Comment 10 Build Bot 2016-09-27 12:00:18 PDT
Created attachment 289991 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Chris Dumez 2016-09-27 12:19:39 PDT
Created attachment 289995 [details]
Patch
Comment 12 Chris Dumez 2016-09-27 12:51:18 PDT
*** Bug 26147 has been marked as a duplicate of this bug. ***
Comment 13 WebKit Commit Bot 2016-09-27 13:57:41 PDT
Comment on attachment 289995 [details]
Patch

Clearing flags on attachment: 289995

Committed r206462: <http://trac.webkit.org/changeset/206462>
Comment 14 WebKit Commit Bot 2016-09-27 13:57:47 PDT
All reviewed patches have been landed.  Closing bug.