WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
162614
[GTK] Simplify platformForUAString
https://bugs.webkit.org/show_bug.cgi?id=162614
Summary
[GTK] Simplify platformForUAString
Michael Catanzaro
Reported
2016-09-27 08:30:11 PDT
It's not possible to build WebKitGTK+ on Windows, this code is all dead. Not looking likely that this will change anytime soon. It's slightly broken currently (the UA includes two semicolons in a row). This code can always be restored later if adding Windows support.
Attachments
Patch
(1.66 KB, patch)
2016-09-27 08:55 PDT
,
Michael Catanzaro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2016-09-27 08:52:59 PDT
Also DirectFB is silly. And we have to claim to be X11 no matter what, as websites expect it. The only time we should risk not including X11 is when running on a Mac, and I'm not even sure about that.
Michael Catanzaro
Comment 2
2016-09-27 08:55:16 PDT
Created
attachment 289948
[details]
Patch
WebKit Commit Bot
Comment 3
2016-09-28 05:57:12 PDT
Comment on
attachment 289948
[details]
Patch Clearing flags on attachment: 289948 Committed
r206513
: <
http://trac.webkit.org/changeset/206513
>
WebKit Commit Bot
Comment 4
2016-09-28 05:57:15 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug