Bug 162612 - [GTK] Improve comment in platformVersionForUAString
Summary: [GTK] Improve comment in platformVersionForUAString
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Blocks: 142074 162610
  Show dependency treegraph
Reported: 2016-09-27 08:21 PDT by Michael Catanzaro
Modified: 2016-10-05 13:22 PDT (History)
3 users (show)

See Also:

Patch (1.53 KB, patch)
2016-09-27 09:11 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2016-09-28 05:35 PDT, Michael Catanzaro
cgarcia: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-09-27 08:21:16 PDT
This function is not implemented properly for Windows or OS X; let's add FIXMEs.
Comment 1 Michael Catanzaro 2016-09-27 09:10:23 PDT
Um, let's add an OS X FIXME only, since we don't support Windows. And remove the existing comment here, since it hasn't been true for a long time.
Comment 2 Michael Catanzaro 2016-09-27 09:11:59 PDT
Created attachment 289951 [details]
Comment 3 Carlos Garcia Campos 2016-09-28 03:42:34 PDT
Comment on attachment 289951 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=289951&action=review

> Source/WebCore/platform/gtk/UserAgentGtk.cpp:108
> -    // We will always claim to be Safari in Mac OS X, since Safari in Linux triggers the iOS path on some websites.
> +    // FIXME: The final result should include OS version, e.g. "Intel Mac OS X 10_8_4".

I don't understand the relationship between the comment removed and the FIXME added. The previous comment tried to explain why we include Mac OS X unconditionally, there's nothing to fix here.
Comment 4 Michael Catanzaro 2016-09-28 05:25:43 PDT
There is something to fix, because we don't include Mac OS X unconditionally. We need the OS X quirk.

Probably adding the new comment should have be done in bug #162612. Let's handle this in that bug to avoid conflicts.
Comment 5 Michael Catanzaro 2016-09-28 05:28:58 PDT
Sorry, I got confused, this is a different place, separate issue. I still want to commit this patch.

 * The old comment is wrong.
 * The new comment is a FIXME that belongs in the same place.

I could split it into two patches if you really want, but seems like wasted effort.
Comment 6 Michael Catanzaro 2016-09-28 05:31:26 PDT
(In reply to comment #5)
> Sorry, I got confused, this is a different place, separate issue. I still
> want to commit this patch.
>  * The old comment is wrong.

No, I got really confused, the comment is right, sorry. I will just add the new one.
Comment 7 Michael Catanzaro 2016-09-28 05:33:34 PDT
Well, it's wrong in that that code will never be executed on Linux; I'll tweak it a bit.
Comment 8 Michael Catanzaro 2016-09-28 05:35:10 PDT
Created attachment 290077 [details]
Comment 9 Michael Catanzaro 2016-10-04 11:36:20 PDT
Ping reviewers
Comment 10 WebKit Commit Bot 2016-10-05 03:36:51 PDT
Comment on attachment 290077 [details]

Rejecting attachment 290077 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 290077, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/gtk/UserAgentGtk.cpp
Hunk #1 FAILED at 105.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/gtk/UserAgentGtk.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Garcia Campos']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2223501
Comment 11 Michael Catanzaro 2016-10-05 13:22:33 PDT
Committed r206825: <http://trac.webkit.org/changeset/206825>