Bug 162605 - [cmake] Added COMPILER_IS_GCC_OR_CLANG variable to simplify conditions.
Summary: [cmake] Added COMPILER_IS_GCC_OR_CLANG variable to simplify conditions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-27 04:49 PDT by Konstantin Tokarev
Modified: 2016-09-27 05:34 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.93 KB, patch)
2016-09-27 04:51 PDT, Konstantin Tokarev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-09-27 04:49:59 PDT
Added COMPILER_IS_GCC_OR_CLANG variable to be used instead of (CMAKE_COMPILER_IS_GNUCXX OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang")

BTW, Clang detection will break when upgrading to CMake 3.0 as CMAKE_CXX_COMPILER_ID will become AppleClang for Clang supplied by Apple. This will be addressed in the following patch.
Comment 1 Konstantin Tokarev 2016-09-27 04:51:23 PDT
Created attachment 289934 [details]
Patch
Comment 2 WebKit Commit Bot 2016-09-27 05:34:18 PDT
Comment on attachment 289934 [details]
Patch

Clearing flags on attachment: 289934

Committed r206430: <http://trac.webkit.org/changeset/206430>
Comment 3 WebKit Commit Bot 2016-09-27 05:34:22 PDT
All reviewed patches have been landed.  Closing bug.