Bug 162602 – [GTK] Install binaries to pkglibexecdir rather than bindir

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

We currently install MiniBrowser and jsc to bindir, which is problematic because it is not possible to parallel-install them. Need to fix this so that we can have parallel-installed GTK+ 3 and GTK+ 4 versions.

[Michael Catanzaro]

Note that LIBEXEC_INSTALL_DIR and EXEC_INSTALL_DIR are the same on all ports except GTK, so this won't break anything for other ports.

[Michael Catanzaro]

Created attachment 289930 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 289930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289930&action=review

> Source/JavaScriptCore/shell/CMakeLists.txt:36
> -    install(TARGETS jsc DESTINATION "${EXEC_INSTALL_DIR}")
> +    install(TARGETS jsc DESTINATION "${LIBEXEC_INSTALL_DIR}")

So, this makes jsc no longer available in path, not sure that's a problem though.

> Tools/MiniBrowser/gtk/CMakeLists.txt:65
> -install(TARGETS MiniBrowser DESTINATION "${EXEC_INSTALL_DIR}")
> +install(TARGETS MiniBrowser DESTINATION "${LIBEXEC_INSTALL_DIR}")

Ditto.

[Michael Catanzaro]

(In reply to comment #3)
> So, this makes jsc no longer available in path

It's intended, so that they can be parallel-installable.

[WebKit Commit Bot]

Comment on attachment 289930 [details]
Patch

Clearing flags on attachment: 289930

Committed r206434: <http://trac.webkit.org/changeset/206434>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.