Bug 162602 - [GTK] Install binaries to pkglibexecdir rather than bindir
Summary: [GTK] Install binaries to pkglibexecdir rather than bindir
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-27 03:13 PDT by Michael Catanzaro
Modified: 2016-09-27 06:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.48 KB, patch)
2016-09-27 03:33 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-09-27 03:13:55 PDT
We currently install MiniBrowser and jsc to bindir, which is problematic because it is not possible to parallel-install them. Need to fix this so that we can have parallel-installed GTK+ 3 and GTK+ 4 versions.
Comment 1 Michael Catanzaro 2016-09-27 03:29:09 PDT
Note that LIBEXEC_INSTALL_DIR and EXEC_INSTALL_DIR are the same on all ports except GTK, so this won't break anything for other ports.
Comment 2 Michael Catanzaro 2016-09-27 03:33:17 PDT
Created attachment 289930 [details]
Patch
Comment 3 Carlos Garcia Campos 2016-09-27 04:13:27 PDT
Comment on attachment 289930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289930&action=review

> Source/JavaScriptCore/shell/CMakeLists.txt:36
> -    install(TARGETS jsc DESTINATION "${EXEC_INSTALL_DIR}")
> +    install(TARGETS jsc DESTINATION "${LIBEXEC_INSTALL_DIR}")

So, this makes jsc no longer available in path, not sure that's a problem though.

> Tools/MiniBrowser/gtk/CMakeLists.txt:65
> -install(TARGETS MiniBrowser DESTINATION "${EXEC_INSTALL_DIR}")
> +install(TARGETS MiniBrowser DESTINATION "${LIBEXEC_INSTALL_DIR}")

Ditto.
Comment 4 Michael Catanzaro 2016-09-27 05:15:03 PDT
(In reply to comment #3)
> So, this makes jsc no longer available in path

It's intended, so that they can be parallel-installable.
Comment 5 WebKit Commit Bot 2016-09-27 06:53:03 PDT
Comment on attachment 289930 [details]
Patch

Clearing flags on attachment: 289930

Committed r206434: <http://trac.webkit.org/changeset/206434>
Comment 6 WebKit Commit Bot 2016-09-27 06:53:07 PDT
All reviewed patches have been landed.  Closing bug.