Bug 162594 - Extend perf dashboard to support multiple pages.
Summary: Extend perf dashboard to support multiple pages.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-26 22:26 PDT by dewei_zhu
Modified: 2016-09-27 14:57 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.72 KB, patch)
2016-09-26 22:28 PDT, dewei_zhu
no flags Details | Formatted Diff | Diff
Patch for landing (5.81 KB, patch)
2016-09-27 14:24 PDT, dewei_zhu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2016-09-26 22:26:27 PDT
Extend perf dashboard to support multiple pages.
Comment 1 dewei_zhu 2016-09-26 22:28:09 PDT
Created attachment 289916 [details]
Patch
Comment 2 Ryosuke Niwa 2016-09-26 22:33:34 PDT
Comment on attachment 289916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289916&action=review

> Websites/perf.webkit.org/public/v3/main.js:60
>          else if (dashboardPages)

There is a bug here. We should be checking dashboardPages.length here as well.

> Websites/perf.webkit.org/public/v3/pages/summary-page.js:30
> -    routeName() { return 'summary'; }
> +    routeName() { return this._route; }

We should use `summary/${this._name}` instead just like we do in DashboardPage.
Comment 3 dewei_zhu 2016-09-27 14:24:50 PDT
Created attachment 290007 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-09-27 14:56:59 PDT
Comment on attachment 290007 [details]
Patch for landing

Clearing flags on attachment: 290007

Committed r206465: <http://trac.webkit.org/changeset/206465>
Comment 5 WebKit Commit Bot 2016-09-27 14:57:03 PDT
All reviewed patches have been landed.  Closing bug.