WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
16259
Inspector should display CDATA section data
https://bugs.webkit.org/show_bug.cgi?id=16259
Summary
Inspector should display CDATA section data
Eric Seidel (no email)
Reported
2007-12-02 13:03:56 PST
Inspector should display CDATA section data Inspect "button-WICD.svg" at the attached link. Notice that none of the script is actually displayed for the <script> tags, since the inspector hides it under the "cdata section". It also shows 4 cdata sections, which makes no sense.
Attachments
[PATCH] Suggested solution
(1.94 KB, patch)
2010-07-26 09:10 PDT
,
Alexander Pavlov (apavlov)
pfeldman
: review-
Details
Formatted Diff
Diff
[PATCH] Comments addressed
(3.68 KB, patch)
2010-07-28 03:37 PDT
,
Alexander Pavlov (apavlov)
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2008-01-29 11:06:31 PST
<
rdar://problem/5712873
>
Alexander Pavlov (apavlov)
Comment 2
2010-07-26 09:10:23 PDT
Created
attachment 62580
[details]
[PATCH] Suggested solution
Alexander Pavlov (apavlov)
Comment 3
2010-07-26 09:15:48 PDT
Once this issue is fixed, users are sure to hit
https://bugs.webkit.org/show_bug.cgi?id=35284
when examining CDATA sections (especially long ones) in the DOM tree. This is fine, since Web Inspector just reports what it gets from the lower levels (the XML parser in this case).
Adam Barth
Comment 4
2010-07-27 07:44:54 PDT
Comment on
attachment 62580
[details]
[PATCH] Suggested solution LGTM. I'm not an inspector expert. Let me know if you'd rather I didn't review patches like this in the future.
Pavel Feldman
Comment 5
2010-07-27 07:59:51 PDT
Comment on
attachment 62580
[details]
[PATCH] Suggested solution Please test that editing is working - we are checking both for node type and style class in the context menu editing code. Also, could you update elements panel test to include new node type?
Alexander Pavlov (apavlov)
Comment 6
2010-07-28 03:37:00 PDT
Created
attachment 62808
[details]
[PATCH] Comments addressed Test augmented and rebaselined. Adding editing caps is non-trivial as it requires the modification of the DOM tree building procedure and doesn't seem to pay off, especially given the XML parsing bug in place.
Alexander Pavlov (apavlov)
Comment 7
2010-07-29 02:06:14 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M LayoutTests/ChangeLog M LayoutTests/inspector/elements-panel-xhtml-structure-expected.txt M LayoutTests/inspector/elements-panel-xhtml-structure.xhtml M WebCore/ChangeLog M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/front-end/ElementsTreeOutline.js Committed
r64267
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug