Bug 162583 - Exception unwinding code should use a CatchScope instead of a ThrowScope.
Summary: Exception unwinding code should use a CatchScope instead of a ThrowScope.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 162351
  Show dependency treegraph
 
Reported: 2016-09-26 16:05 PDT by Mark Lam
Modified: 2016-09-26 16:14 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch. (2.03 KB, patch)
2016-09-26 16:10 PDT, Mark Lam
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-09-26 16:05:13 PDT
This is because the exception unwinding code does not throw an exception.  It only inspects the exception and passes it to the appropriate handler.
Comment 1 Mark Lam 2016-09-26 16:10:04 PDT
Created attachment 289885 [details]
proposed patch.
Comment 2 Geoffrey Garen 2016-09-26 16:11:57 PDT
Comment on attachment 289885 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2016-09-26 16:14:57 PDT
Thanks for the review.  Landed in r206401: <http://trac.webkit.org/r206401>.