Summary: Add an Option to disable the CodeCache Useful when benchmarking to ensure we do more parsing.
Created attachment 289879 [details] [PATCH] Proposed Fix
Comment on attachment 289879 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=289879&action=review > Source/JavaScriptCore/ChangeLog:8 > + * runtime/CodeCache.cpp: We could also use this in EvalCodeCache. Let me know if you think we should as well.
Comment on attachment 289879 [details] [PATCH] Proposed Fix r=me
Comment on attachment 289879 [details] [PATCH] Proposed Fix Clearing flags on attachment: 289879 Committed r206400: <http://trac.webkit.org/changeset/206400>
All reviewed patches have been landed. Closing bug.
Comment on attachment 289879 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=289879&action=review > Source/JavaScriptCore/runtime/Options.h:391 > + v(bool, useCodeCache, true, Normal, "If false, the parser will not use the code cache.") \ Nit: This might be confusing with the word "parser" in it since the parser has its own cache and this cache is on top of the parser. I'd just say: "If false, we won't use the unlinked byte code cache" or something similar.
(In reply to comment #2) > Comment on attachment 289879 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289879&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + * runtime/CodeCache.cpp: > > We could also use this in EvalCodeCache. Let me know if you think we should > as well. They're two different caches. I'd say that if we find an option for the eval code cache useful we can add it in a separate patch. I think it's good to have this option just be for the unlinked code cache.