Bug 162577 - [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible with WKSelectionGranularityCharacter
Summary: [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-26 14:12 PDT by mitz
Modified: 2016-09-27 11:34 PDT (History)
3 users (show)

See Also:


Attachments
Avoid clipping the selection UI when it is not confined to an element (1.45 KB, patch)
2016-09-26 14:23 PDT, mitz
no flags Details | Formatted Diff | Diff
Avoid clipping the selection UI when it is not confined to an element (14.36 KB, patch)
2016-09-27 10:20 PDT, mitz
simon.fraser: review+
Details | Formatted Diff | Diff
Avoid clipping the selection UI when it is not confined to an element (14.45 KB, patch)
2016-09-27 10:56 PDT, mitz
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2016-09-26 14:12:11 PDT
When selectionGranularity is set to WKSelectionGranularityCharacter, the selection UI is broken: the selection highlights and the selection handles are never visible.
Comment 1 mitz 2016-09-26 14:13:59 PDT
<rdar://problem/28481984>
Comment 2 mitz 2016-09-26 14:23:34 PDT
Created attachment 289868 [details]
Avoid clipping the selection UI when it is not confined to an element
Comment 3 Simon Fraser (smfr) 2016-09-26 14:27:17 PDT
Comment on attachment 289868 [details]
Avoid clipping the selection UI when it is not confined to an element

I think we should go the extra mile here to add testing.
Comment 4 mitz 2016-09-27 10:20:09 PDT
Created attachment 289965 [details]
Avoid clipping the selection UI when it is not confined to an element

Added a test. I will need help making it run only in iOS with WebKit2.
Comment 5 Simon Fraser (smfr) 2016-09-27 10:28:06 PDT
Comment on attachment 289965 [details]
Avoid clipping the selection UI when it is not confined to an element

View in context: https://bugs.webkit.org/attachment.cgi?id=289965&action=review

> Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:82
> +    readonly attribute object selectionRangeViewRects;

Would be nice if a comment said what this returned (like "Returns an array of objects with 'left', 'top', 'width', 'height' properties"
Comment 6 mitz 2016-09-27 10:56:00 PDT
Created attachment 289980 [details]
Avoid clipping the selection UI when it is not confined to an element

Tried to fix failing builds.
Comment 7 mitz 2016-09-27 11:34:08 PDT
Fixed in <https://trac.webkit.org/r206449>.