Bug 162575 – Seeking video doesn't update seek position

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Wenson Hsieh]

Seeking video doesn't update seek position

[Wenson Hsieh]

<rdar://problem/28457219>

[Wenson Hsieh]

Created attachment 289858 [details]
Patch

[Wenson Hsieh]

Created attachment 289865 [details]
Fix unused function on non-media-remote builds.

[Build Bot]

Comment on attachment 289865 [details]
Fix unused function on non-media-remote builds.

Attachment 289865 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2150151

New failing tests:
media/remote-control-command-is-user-gesture.html
media/remote-control-command-seek.html

[Build Bot]

Created attachment 289872 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289865 [details]
Fix unused function on non-media-remote builds.

Attachment 289865 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2150159

New failing tests:
media/remote-control-command-is-user-gesture.html
media/remote-control-command-seek.html

[Build Bot]

Created attachment 289873 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Wenson Hsieh]

Created attachment 289878 [details]
Further simplified the patch.

[Jer Noble]

Comment on attachment 289878 [details]
Further simplified the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=289878&action=review

r=me, with nits

> Source/WebCore/ChangeLog:20
> +        Also, when responding to a remote seek, perform the seek with no tolerance. This prevents the playhead from
> +        stuttering at the end of a seek from the final requested destination of the seek to the last actually seeked
> +        time in the video.

We should add a FIXME about this, because it doesn't match the behavior of the inline controls.  For the inline controls, we do a fastSeek() for 'mousedown' and 'mousemove' and a zero-tolerance seek for 'mouseup'.  We'd need an explicit "end seeking" command to implement this though.

> Source/WebCore/platform/audio/PlatformMediaSessionManager.h:113
> +    void reloadSupportedCommands() const;

This is probably from a different patch.

> Source/WebCore/platform/audio/mac/MediaSessionManagerMac.h:-57
> -    bool m_isInBackground { false };

Is this necessary?

[Wenson Hsieh]

Comment on attachment 289878 [details]
Further simplified the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=289878&action=review

>> Source/WebCore/ChangeLog:20
>> +        time in the video.
> 
> We should add a FIXME about this, because it doesn't match the behavior of the inline controls.  For the inline controls, we do a fastSeek() for 'mousedown' and 'mousemove' and a zero-tolerance seek for 'mouseup'.  We'd need an explicit "end seeking" command to implement this though.

FIXME added. Thanks!

>> Source/WebCore/platform/audio/PlatformMediaSessionManager.h:113
>> +    void reloadSupportedCommands() const;
> 
> This is probably from a different patch.

Oh, I meant to remove this! Done.

>> Source/WebCore/platform/audio/mac/MediaSessionManagerMac.h:-57
>> -    bool m_isInBackground { false };
> 
> Is this necessary?

True -- we don't need to remove this. Added back in.

[Wenson Hsieh]

Committed r206399: <http://trac.webkit.org/changeset/206399>