Bug 162568 - [WK2] BlobDownloadClient should use asynchronous IPC to decide destination path
Summary: [WK2] BlobDownloadClient should use asynchronous IPC to decide destination path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 162543
  Show dependency tree / graph
 
Reported: 2016-09-26 10:41 PDT by Chris Dumez
Modified: 2016-09-26 15:22 PDT (History)
6 users (show)

See Also:

Attachments
WIP patch (17.87 KB, patch)
2016-09-26 13:16 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP patch (21.99 KB, patch)
2016-09-26 13:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (28.06 KB, patch)
2016-09-26 14:19 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-09-26 10:41:47 PDT 
BlobDownloadClient should use asynchronous IPC to decide destination path. It currently uses a synchronous IPC to do so which leads to flakiness such as Bug 162543.
Comment 1 Chris Dumez 2016-09-26 13:16:43 PDT 
Created attachment 289854 [details]
WIP patch
Comment 2 Chris Dumez 2016-09-26 13:38:21 PDT 
Created attachment 289862 [details]
WIP patch
Comment 3 Chris Dumez 2016-09-26 14:19:13 PDT 
Created attachment 289866 [details]
Patch
Comment 4 Alex Christensen 2016-09-26 14:35:11 PDT 
Comment on attachment 289866 [details]
Patch

We really need a BlobDataTask and have it and NetworkDataTask inherit from a common interface.
Comment 5 Chris Dumez 2016-09-26 15:22:47 PDT 
Comment on attachment 289866 [details]
Patch

Clearing flags on attachment: 289866

Committed r206397: <http://trac.webkit.org/changeset/206397>
Comment 6 Chris Dumez 2016-09-26 15:22:54 PDT 
All reviewed patches have been landed.  Closing bug.