Bug 162566 - LayoutTest media/media-source/media-source-delaying-load-event.html is a flaky failure
Summary: LayoutTest media/media-source/media-source-delaying-load-event.html is a flak...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-26 10:26 PDT by Ryan Haddad
Modified: 2016-09-28 13:14 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2016-09-26 16:25 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-09-26 10:26:43 PDT 
LayoutTest media/media-source/media-source-delaying-load-event.html is a flaky failure

https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r206375%20(15194)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmedia-source%2Fmedia-source-delaying-load-event.html

--- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/media/media-source/media-source-delaying-load-event-expected.txt
+++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/media/media-source/media-source-delaying-load-event-actual.txt
@@ -2,6 +2,6 @@
 
 EXPECTED (source.readyState == 'closed') OK
 RUN(video.src = URL.createObjectURL(source))
-EVENT(load)
+FAIL: did not end fast enough
 END OF TEST
Comment 1 Ryan Haddad 2016-09-26 10:27:07 PDT 
This test was added with https://trac.webkit.org/changeset/205863.
Comment 2 Ryan Haddad 2016-09-26 13:58:32 PDT 
Jer, could you take a look at this? The test is failing quite frequently.
Comment 3 Jer Noble 2016-09-26 14:26:15 PDT 
(In reply to comment #2)
> Jer, could you take a look at this? The test is failing quite frequently.

Hm, the test is set to "time out" in 100ms. Maybe that's just too short a timeout for an overworked bot. We should just remove that line and see it if really times out flakily, or if it's occasionally taking just > 100ms.
Comment 4 Ryan Haddad 2016-09-26 16:25:11 PDT 
Created attachment 289887 [details]
Patch
Comment 5 WebKit Commit Bot 2016-09-26 20:08:46 PDT 
Comment on attachment 289887 [details]
Patch

Clearing flags on attachment: 289887

Committed r206409: <http://trac.webkit.org/changeset/206409>
Comment 6 WebKit Commit Bot 2016-09-26 20:08:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Jer Noble 2016-09-26 21:57:13 PDT 
Thanks Ryan! Let me know if this test still flakes and I should go hunting for a timing issue.
Comment 8 Ryan Haddad 2016-09-28 13:14:32 PDT 
No flakes since r206409, so it looks like we're good.