Bug 162550 - [Win][Debug] Compile fix.
Summary: [Win][Debug] Compile fix.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-26 01:27 PDT by Per Arne Vollan
Modified: 2016-09-26 08:25 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2016-09-26 02:27 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.29 KB, patch)
2016-09-26 02:35 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-09-26 01:27:18 PDT 
WebCore::SimpleLineLayout::FragmentForwardIterator is missing the == operator:

1>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\xutility(947): error C2678: binary '==': no operator found which takes a left-hand operand of type 'WebCore::SimpleLineLayout::FragmentForwardIterator' (or there is no acceptable conversion)
Comment 1 Per Arne Vollan 2016-09-26 02:10:55 PDT 
The '==' operator is needed in debug mode.

From xutility: 

// TEMPLATE FUNCTION _Debug_range
template<class _InIt> inline
void _Debug_range2(_InIt _First, _InIt _Last,
_Dbfile_t, _Dbline_t, input_iterator_tag)
{	// test iterator pair for valid range, arbitrary iterators
    static_cast<void>(_First == _Last);	// make sure they're comparable
}
Comment 2 Per Arne Vollan 2016-09-26 02:27:23 PDT 
Created attachment 289812 [details]
Patch
Comment 3 Per Arne Vollan 2016-09-26 02:33:08 PDT 
rdar://problem/28448683
Comment 4 Per Arne Vollan 2016-09-26 02:35:44 PDT 
Created attachment 289813 [details]
Patch
Comment 5 WebKit Commit Bot 2016-09-26 08:25:38 PDT 
Comment on attachment 289813 [details]
Patch

Clearing flags on attachment: 289813

Committed r206375: <http://trac.webkit.org/changeset/206375>
Comment 6 WebKit Commit Bot 2016-09-26 08:25:43 PDT 
All reviewed patches have been landed.  Closing bug.