Bug 162541 – Regression(r206356): Caused crashes for !NETWORK_SESSION code path

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Regression(r206356): Caused crashes for !NETWORK_SESSION code path:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x0000000110cb0627 WTFCrash + 39 (Assertions.cpp:323)
1   com.apple.WebKit              	0x000000010c4d8517 WebKit::Download::platformInvalidate() + 87 (DownloadMac.mm:122)
2   com.apple.WebKit              	0x000000010c4d044c WebKit::Download::~Download() + 44 (Download.cpp:74)
3   com.apple.WebKit              	0x000000010c4d05b5 WebKit::Download::~Download() + 21 (Download.cpp:75)
4   com.apple.WebKit              	0x000000010c4d05d9 WebKit::Download::~Download() + 25 (Download.cpp:71)
5   com.apple.WebKit              	0x000000010c4ddd85 WTF::KeyValuePairHashTraits<WTF::HashTraits<WebKit::DownloadID>, WTF::HashTraits<std::__1::unique_ptr<WebKit::Download, std::__1::default_delete<WebKit::Download> > > >::customDeleteBucket(WTF::KeyValuePair<WebKit::DownloadID, std::__1::unique_ptr<WebKit::Download, std::__1::default_delete<WebKit::Download> > >&) + 197 (HashTraits.h:307)
6   com.apple.WebKit              	0x000000010c4ddcb5 std::__1::enable_if<HashTraitHasCustomDelete<WTF::HashMap<WebKit::DownloadID, std::__1::unique_ptr<WebKit::Download, std::__1::default_delete<WebKit::Download> >, WTF::DownloadIDHash, WTF::HashTraits<WebKit::DownloadID>, WTF::HashTraits<std::__1::unique_ptr<WebKit::Download, std::__1::default_delete<WebKit::Download> > > >::KeyValuePairTraits,

[Chris Dumez]

Created attachment 289791 [details]
Patch

[Chris Dumez]

Comment on attachment 289791 [details]
Patch

I confirmed that the crashes are gone locally with NETWORK_SESSION disabled.

[WebKit Commit Bot]

Comment on attachment 289791 [details]
Patch

Clearing flags on attachment: 289791

Committed r206367: <http://trac.webkit.org/changeset/206367>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.