Bug 162528 - [GTK][ThreadedCompositor] Some videos are not rendered correctly
Summary: [GTK][ThreadedCompositor] Some videos are not rendered correctly
Status: RESOLVED DUPLICATE of bug 173796
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-24 05:49 PDT by Guilaume Ayoub
Modified: 2017-08-02 07:02 PDT (History)
7 users (show)

See Also:


Attachments
Screenshot with thumbnail of the correct rendering (319.43 KB, image/png)
2016-09-24 05:49 PDT, Guilaume Ayoub
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guilaume Ayoub 2016-09-24 05:49:30 PDT
Created attachment 289744 [details]
Screenshot with thumbnail of the correct rendering

Some videos (on Youtube for example) are not displayed correctly. For example:

https://www.youtube.com/watch?v=Y6jrVg_Mz8Y

The problem can be seen when this video is played with 360p resolution, but not with 240p. It looks like a 3D texture bug.

I don't remember exactly when whis bug appeared, but it was probably during the 2.13.x releases. I can bisect if needed.
Comment 1 Michael Catanzaro 2016-09-25 09:28:50 PDT
(In reply to comment #0)
> I can bisect if needed.

This would be awesome!
Comment 2 Guilaume Ayoub 2016-09-26 08:16:39 PDT
The bug has been introduced by 2.13.4 (2.13.3 works well). I'm cloning the repository to find the bad commit.
Comment 3 Guilaume Ayoub 2016-09-27 10:09:09 PDT
(In reply to comment #2)
> I'm cloning the repository to find the bad commit.

I was a bit optimistic. Bisecting the error is probably too long and I don't even know the commits corresponding to the WebkitGTK versions.

Judging from the 2.13.4 changelog, I've tried to deactivate the threaded compositor (using WEBKIT_DISABLE_COMPOSITING_MODE), but it doesn't solve the problem.

I'm trying to find the commit in the git log.
Comment 4 Michael Catanzaro 2016-09-28 00:55:54 PDT
(In reply to comment #3)
> I was a bit optimistic. Bisecting the error is probably too long and I don't
> even know the commits corresponding to the WebkitGTK versions.

Those releases were unusually close together, so there are only ~400 revisions to bisect. 2.13.3 is r203344 and 2.13.4 is r203768.
Comment 5 Guilaume Ayoub 2016-10-04 00:17:38 PDT
I've spent a lot of time bisecting and I should have cleaned the directory: keeping the compiled stuff between 2.13.3 and 2.13.4 made me compile a 2.13.4 (and even a 2.14.0) without the bug. :'(.

Of course, when I build from a fresh clone, the bug comes back.

I'll bisect and *clean before each compilation* soon!
Comment 6 Guilaume Ayoub 2016-10-08 03:24:41 PDT
This video is another strange example:

http://www.todaypost.cf/2016/10/ascii-fluid-dynamics.html

The video is OK from 00:00 to 00:10, and then suddenly gets the problem. If I click on the timeline, it:
- sometimes plays the video with the problem, or
- sometimes draws 1 frame without the problem and crashes.

I didn't give up the idea of a clean bisect, but I need some time…
Comment 7 Guilaume Ayoub 2016-10-10 02:46:58 PDT
I've bisected, the bug is in revision 203596:

[GTK] Enable threaded compositor by default
https://bugs.webkit.org/show_bug.cgi?id=160079

I don't know why setting WEBKIT_DISABLE_COMPOSITING_MODE didn't help to find this before… Can I do anything to help?
Comment 8 Miguel Gomez 2016-10-10 08:54:46 PDT
I've been trying to reproduce this both with ToT and with r203596, but I'm not able to. Both videos work fine for me using the MiniBrowser.

What I do see is that in the second video, when reaching second 10 more or less, the resolution increases from 320x240 to 472x352, which could be related to the problem.
Comment 9 Guilaume Ayoub 2016-10-21 05:18:21 PDT
The bug is caused by gstreamer-plugins-vaapi, everything's OK when I remove it.
Comment 10 Guilaume Ayoub 2016-10-21 06:48:43 PDT
Full report:

- With gst-plugins-vaapi:

  - Some videos always work, with Webkit and Totem, X or Wayland.
  - Other videos:
    - work with Totem + X,
    - don't work with Totem + Wayland: black window,
    - don't work with Webkit (X or Wayland): problem shown in attachment.

- Without gst-plugins-vaapi: everything works.

Of course, this bug is not really important, I can remove gst-plugins-vaapi. But if anyone is interested in solving it, I can test whatever you want.
Comment 12 Víctor M. Jáquez L. 2016-10-21 07:02:15 PDT
(In reply to comment #10)
>
>     - don't work with Totem + Wayland: black window,

Known issue: https://bugzilla.gnome.org/show_bug.cgi?id=772838
Comment 13 Guilaume Ayoub 2017-03-22 00:55:49 PDT
Does your fix in Gstreamer-vaapi 1.11.3 fix this problem too?
Comment 14 Víctor M. Jáquez L. 2017-08-02 07:02:05 PDT

*** This bug has been marked as a duplicate of bug 173796 ***