Bug 162516 - Refactor URLParser
Summary: Refactor URLParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-23 15:19 PDT by Alex Christensen
Modified: 2016-09-23 15:34 PDT (History)
0 users

See Also:

Attachments
Patch (32.36 KB, patch)
2016-09-23 15:21 PDT, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-23 15:19:02 PDT 
Refactor URLParser
Comment 1 Alex Christensen 2016-09-23 15:21:34 PDT 
Created attachment 289714 [details]
Patch
Comment 2 Brady Eidson 2016-09-23 15:26:14 PDT 
Comment on attachment 289714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289714&action=review

> Source/WebCore/platform/URLParser.cpp:432
> -    return *iterator == ':' || *iterator == '|';
> +    if (*iterator == ':')
> +        return true;
> +    if (*iterator == '|')
> +        return true;
> +    return false;

Why this change? Was fine the old way.
Comment 3 Alex Christensen 2016-09-23 15:33:19 PDT 
That change will be needed soon.  One is a syntax error and one is not.
Comment 4 Alex Christensen 2016-09-23 15:34:56 PDT 
http://trac.webkit.org/changeset/206334