Currently the memory pool size is set based on the CPU. The x64 version uses a 1GB pool size by default which is very large value. This value should be able to be specified by the port to allow overriding of the defaults.
Created attachment 289715 [details] Add macro This allows the size in MB to be specified by the port. In CMake you would use add_definitions(-DFIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB=<value>) within the Platform cmake file within JavaScriptCore. I'm open to changes to the name and also not sure if there should be any sort of static assert that ensures the validity of the value.
Comment on attachment 289715 [details] Add macro LGTM. Did you want this reviewed? If so, please set the patch r attributes to r?. If you don't have committer privileges and want the patch committed, please set the patch cq attribute to cq?.
Comment on attachment 289715 [details] Add macro View in context: https://bugs.webkit.org/attachment.cgi?id=289715&action=review r=me with suggestion. > Source/JavaScriptCore/jit/ExecutableAllocator.h:75 > +#if defined FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB nit: I prefer #ifdef FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB or # if defined(FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB)
Created attachment 289719 [details] Fix nits Fixing nits
Comment on attachment 289719 [details] Fix nits View in context: https://bugs.webkit.org/attachment.cgi?id=289719&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.h:75 > +#ifdef FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB I'd preferred #if defined(FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB), it would be more in line with following #elif
Committed r206379: <http://trac.webkit.org/changeset/206379>