Bug 162510 - LayoutTest fast/images/animated-gif-restored-from-bfcache.html is a flaky failure
Summary: LayoutTest fast/images/animated-gif-restored-from-bfcache.html is a flaky fai...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-23 13:36 PDT by Ryan Haddad
Modified: 2017-04-06 15:50 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2017-03-31 15:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-09-23 13:36:34 PDT
LayoutTest fast/images/animated-gif-restored-from-bfcache.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r206315%20(8366)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fimages%2Fanimated-gif-restored-from-bfcache.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/fast/images/animated-gif-restored-from-bfcache-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/fast/images/animated-gif-restored-from-bfcache-actual.txt
@@ -1,5 +1,5 @@
 Test that animated GIFs resume animating after restoring a page from the back forward cache. To test manually, click here to visit about:blank, then press the browser's back button. On success, you should see a square that continuously animates through various shades of green followed by the word 'PASS'.
 
 
-PASS
+FAIL
Comment 1 Ryan Haddad 2016-09-23 13:38:58 PDT
This is a very recent regression, with the first occurrence on the flakiness dashboard being with https://trac.webkit.org/changeset/206188
Comment 2 zalan 2016-09-23 17:26:41 PDT
It looks unrelated.
Comment 3 Alexey Proskuryakov 2016-09-25 18:45:23 PDT
This test has been flaky for a long time on some bots, especially on slower ones (like GuardMalloc and ASan). But it clearly got worse in the last couple of weeks.

There is a 100 ms timeout in the test, which can't be right.
Comment 4 Ryan Haddad 2016-09-28 16:25:47 PDT
Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/206559
Comment 5 Alexey Proskuryakov 2017-03-31 13:20:49 PDT
Looking at other bots, I see that the recent regression in frequency started on or before r214508. 

Kind of willing to blame <http://trac.webkit.org/r214503>.
Comment 6 Radar WebKit Bug Importer 2017-03-31 15:27:18 PDT
<rdar://problem/31380650>
Comment 7 Chris Dumez 2017-03-31 15:33:28 PDT
Created attachment 306020 [details]
Patch
Comment 8 Alexey Proskuryakov 2017-03-31 16:31:11 PDT
Comment on attachment 306020 [details]
Patch

Thank you!

Curious if there was something in that change that made it more common.
Comment 9 Chris Dumez 2017-03-31 17:04:27 PDT
(In reply to Alexey Proskuryakov from comment #8)
> Comment on attachment 306020 [details]
> Patch
> 
> Thank you!
> 
> Curious if there was something in that change that made it more common.

I looked again on my change but it is really restricted to SVG animations. I do not see how it would impact the timing of GIF animations.

Anyway, the test was inherently flaky any timing change you impact it.
Comment 10 WebKit Commit Bot 2017-03-31 17:31:37 PDT
Comment on attachment 306020 [details]
Patch

Clearing flags on attachment: 306020

Committed r214706: <http://trac.webkit.org/changeset/214706>
Comment 11 WebKit Commit Bot 2017-03-31 17:31:41 PDT
All reviewed patches have been landed.  Closing bug.