LayoutTest fast/images/animated-gif-restored-from-bfcache.html is a flaky failure https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r206315%20(8366)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fimages%2Fanimated-gif-restored-from-bfcache.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/fast/images/animated-gif-restored-from-bfcache-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/fast/images/animated-gif-restored-from-bfcache-actual.txt @@ -1,5 +1,5 @@ Test that animated GIFs resume animating after restoring a page from the back forward cache. To test manually, click here to visit about:blank, then press the browser's back button. On success, you should see a square that continuously animates through various shades of green followed by the word 'PASS'. -PASS +FAIL
This is a very recent regression, with the first occurrence on the flakiness dashboard being with https://trac.webkit.org/changeset/206188
It looks unrelated.
This test has been flaky for a long time on some bots, especially on slower ones (like GuardMalloc and ASan). But it clearly got worse in the last couple of weeks. There is a 100 ms timeout in the test, which can't be right.
Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/206559
Looking at other bots, I see that the recent regression in frequency started on or before r214508. Kind of willing to blame <http://trac.webkit.org/r214503>.
<rdar://problem/31380650>
Created attachment 306020 [details] Patch
Comment on attachment 306020 [details] Patch Thank you! Curious if there was something in that change that made it more common.
(In reply to Alexey Proskuryakov from comment #8) > Comment on attachment 306020 [details] > Patch > > Thank you! > > Curious if there was something in that change that made it more common. I looked again on my change but it is really restricted to SVG animations. I do not see how it would impact the timing of GIF animations. Anyway, the test was inherently flaky any timing change you impact it.
Comment on attachment 306020 [details] Patch Clearing flags on attachment: 306020 Committed r214706: <http://trac.webkit.org/changeset/214706>
All reviewed patches have been landed. Closing bug.