RESOLVED INVALID 162500
Remove unneeded assert 
https://bugs.webkit.org/show_bug.cgi?id=162500
Summary Remove unneeded assert
Ryan Haddad
Reported 2016-09-23 11:31:43 PDT
Remove unneeded assert in InspectorOverlay.cpp
Attachments
Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-09-23 11:34:54 PDT
ASSERTION FAILED: result /Volumes/Data/slave/gala-debug-archive/build/OpenSource/Source/WebCore/inspector/InspectorOverlay.cpp(927) : void WebCore::evaluateCommandInOverlay(WebCore::Page *, Ref<Inspector::InspectorArray> &&) 1 0x10fbc1680 WTFCrash 2 0x115cd5eab WebCore::evaluateCommandInOverlay(WebCore::Page*, WTF::Ref<Inspector::InspectorArray>&&) 3 0x115cd5d14 WebCore::InspectorOverlay::evaluateInOverlay(WTF::String const&, WTF::String const&) 4 0x115cd2fb4 WebCore::InspectorOverlay::overlayPage() 5 0x115cd347b WebCore::InspectorOverlay::update() 6 0x115cd37b5 WebCore::InspectorOverlay::highlightNode(WebCore::Node*, WebCore::HighlightConfig const&) 7 0x115c749aa WebCore::InspectorDOMAgent::highlightNode(WTF::String&, Inspector::InspectorObject const&, int const*, WTF::String const*) 8 0x115c74b62 non-virtual thunk to WebCore::InspectorDOMAgent::highlightNode(WTF::String&, Inspector::InspectorObject const&, int const*, WTF::String const*) 9 0x10f47a624 Inspector::DOMBackendDispatcher::highlightNode(long, WTF::RefPtr<Inspector::InspectorObject>&&) 10 0x10f475026 Inspector::DOMBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<Inspector::InspectorObject>&&) 11 0x10f461142 Inspector::BackendDispatcher::dispatch(WTF::String const&) 12 0x115c2d82f WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) 13 0x115c99a52 WebCore::InspectorBackendDispatchTask::timerFired() 14 0x115c9b4d8 void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (WebCore::InspectorBackendDispatchTask::*&)(), WebCore::InspectorBackendDispatchTask*>&>(std::__1::__bind<void (WebCore::InspectorBackendDispatchTask::*&)(), WebCore::InspectorBackendDispatchTask*>&&&) 15 0x115c9b3ac std::__1::__function::__func<std::__1::__bind<void (WebCore::InspectorBackendDispatchTask::*&)(), WebCore::InspectorBackendDispatchTask*>, std::__1::allocator<std::__1::__bind<void (WebCore::InspectorBackendDispatchTask::*&)(), WebCore::InspectorBackendDispatchTask*> >, void ()>::operator()() 16 0x114d50d8a std::__1::function<void ()>::operator()() const 17 0x114d50c9c WebCore::Timer::fired() 18 0x11734a03a WebCore::ThreadTimers::sharedTimerFiredInternal() 19 0x11734b281 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const 20 0x11734b24d void std::__1::__invoke_void_return_wrapper<void>::__call<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0&>(WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0&&&) 21 0x11734b1ec std::__1::__function::__func<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, std::__1::allocator<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0>, void ()>::operator()() 22 0x114d50d8a std::__1::function<void ()>::operator()() const 23 0x116697a0f WebCore::MainThreadSharedTimer::fired() 24 0x116697e09 WebCore::timerFired(__CFRunLoopTimer*, void*) 25 0x7fffa0eeeb94 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 26 0x7fffa0eee823 __CFRunLoopDoTimer 27 0x7fffa0eee37a __CFRunLoopDoTimers 28 0x7fffa0ee5871 __CFRunLoopRun 29 0x7fffa0ee4ed8 CFRunLoopRunSpecific 30 0x10e5715fc runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) 31 0x10e56fcdd runTestingServerLoop()
Note You need to log in before you can comment on or make changes to this bug.