Bug 162498 - Allow Seeking from the now playing controls
Summary: Allow Seeking from the now playing controls
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
Keywords: InRadar
Depends on:
Reported: 2016-09-23 11:00 PDT by Jer Noble
Modified: 2016-09-24 20:02 PDT (History)
4 users (show)

See Also:

Patch (1.63 KB, patch)
2016-09-23 11:02 PDT, Jer Noble
bdakin: review+
jer.noble: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-09-23 11:00:44 PDT
Allow Seeking from the now playing controls
Comment 1 Jer Noble 2016-09-23 11:02:12 PDT
Created attachment 289692 [details]
Comment 2 Jer Noble 2016-09-23 11:02:55 PDT
Comment 3 Wenson Hsieh 2016-09-23 11:04:43 PDT
We discussed this change, and agree that it makes sense. r=me!
Comment 4 Jer Noble 2016-09-23 12:43:16 PDT
Committed r206322: <http://trac.webkit.org/changeset/206322>
Comment 5 Wenson Hsieh 2016-09-24 20:02:48 PDT
Hm...I just realized looking at this change again that this change did not fix the problem. In fact, we were already marking MRMediaRemoteCommandSeekToPlaybackPosition as enabled in the code below this change.

`CFArrayAppendValue(commandInfoArray.get(), seekCommandInfo.get());`

The problem lies elsewhere, in MediaRemote.