AX: iOS: Tapping <input> in Safari zooms in a bit when page has max scale = 1

[Nan Wang]

We were ignoring force always user scalable for input field but we missed a case where web authors sometimes set maximum scale to 1 instead of user-scalable=no.

<rdar://problem/27137434>

[Nan Wang]

Created attachment 289628 [details]
patch

[WebKit Commit Bot]

Attachment 289628 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nan Wang]

Created attachment 289629 [details]
patch

fixed a typo

[WebKit Commit Bot]

Attachment 289629 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nan Wang]

Created attachment 289634 [details]
patch

fixing timeout tests.

[WebKit Commit Bot]

Attachment 289634 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nan Wang]

Created attachment 289640 [details]
patch

let's fix the tests again :(

[WebKit Commit Bot]

Attachment 289640 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nan Wang]

Created attachment 289648 [details]
patch

I figured touch events are not supported in layout tests

[WebKit Commit Bot]

Attachment 289648 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nan Wang]

Created attachment 289662 [details]
patch

Moved the tests to the right place.

[WebKit Commit Bot]

Attachment 289662 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nan Wang]

Created attachment 289665 [details]
patch

Actually those tests were failing on my local machine after moving to a different place :(
Now fixed it, should be good...

[WebKit Commit Bot]

Attachment 289665 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 289665 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289665&action=review

> Source/WebCore/page/ViewportConfiguration.h:95
> +    double maximumScaleIgnoringForceAlwaysScaling() const { return m_configuration.maximumScale; }

Maybe "maximumScaleIgnoringAlwaysScalable()"

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:332
> +    if (!m_viewportConfiguration.allowsUserScalingIgnoringForceAlwaysScaling())

I literally cannot parse "allowsUserScalingIgnoringForceAlwaysScaling"

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:333
> +        return m_page->pageScaleFactor();

This seems wrong. Shouldn't this return m_viewportConfiguration.maximumScale() ?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2553
> +    information.maximumScaleFactorIgnoringForceAlwaysScaling = maximumPageScaleFactorIgnoringForceAlwaysScaling();

Can we use "ignoringForceAlwaysScalable everywhere?

[Nan Wang]

Comment on attachment 289665 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289665&action=review

>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:332
>> +    if (!m_viewportConfiguration.allowsUserScalingIgnoringForceAlwaysScaling())
> 
> I literally cannot parse "allowsUserScalingIgnoringForceAlwaysScaling"

I'll try to rename this with ignoringForceAlwaysScalable

>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:333
>> +        return m_page->pageScaleFactor();
> 
> This seems wrong. Shouldn't this return m_viewportConfiguration.maximumScale() ?

I'm not an expert on this but I copied the logic from WebPage::maximumPageScaleFactor()

>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2553
>> +    information.maximumScaleFactorIgnoringForceAlwaysScaling = maximumPageScaleFactorIgnoringForceAlwaysScaling();
> 
> Can we use "ignoringForceAlwaysScalable everywhere?

ok

[Nan Wang]

Created attachment 290257 [details]
patch

Renamed IgnoringForceAlwaysScaling to IgnoringAlwaysScalable.

[WebKit Commit Bot]

Attachment 290257 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 290257 [details]
patch

Clearing flags on attachment: 290257

Committed r206626: <http://trac.webkit.org/changeset/206626>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[siim]

Still broken in iOS 16.4.1