WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
162462
SlotVisitor::visitChildren() could be better at calling cell->visitChildren()
https://bugs.webkit.org/show_bug.cgi?id=162462
Summary
SlotVisitor::visitChildren() could be better at calling cell->visitChildren()
Filip Pizlo
Reported
2016-09-22 14:25:07 PDT
For starters, it shouldn't go looking for the VM every time.
Attachments
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2016-09-22 14:25:57 PDT
What if the right solution here is to JIT the SlotVisitor? That would be cool.
Filip Pizlo
Comment 2
2016-09-22 14:26:21 PDT
(In reply to
comment #1
)
> What if the right solution here is to JIT the SlotVisitor? That would be > cool.
BTW that's not insane. That's what Jikes RVM did: we had a specialized compiler for the visiting methods. It was a progression.
Filip Pizlo
Comment 3
2017-01-13 10:47:33 PST
But an even better solution would be to just make methodTable() not terrible.
Mark Lam
Comment 4
2021-02-01 23:55:39 PST
Sorry. Closed the wrong bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug