Bug 162462 - SlotVisitor::visitChildren() could be better at calling cell->visitChildren()
Summary: SlotVisitor::visitChildren() could be better at calling cell->visitChildren()
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-22 14:25 PDT by Filip Pizlo
Modified: 2021-02-01 23:55 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-09-22 14:25:07 PDT
For starters, it shouldn't go looking for the VM every time.
Comment 1 Filip Pizlo 2016-09-22 14:25:57 PDT
What if the right solution here is to JIT the SlotVisitor?  That would be cool.
Comment 2 Filip Pizlo 2016-09-22 14:26:21 PDT
(In reply to comment #1)
> What if the right solution here is to JIT the SlotVisitor?  That would be
> cool.

BTW that's not insane.  That's what Jikes RVM did: we had a specialized compiler for the visiting methods.  It was a progression.
Comment 3 Filip Pizlo 2017-01-13 10:47:33 PST
But an even better solution would be to just make methodTable() not terrible.
Comment 4 Mark Lam 2021-02-01 23:55:39 PST
Sorry.  Closed the wrong bug.