Bug 162420 - Add a new runtime flag for work on modern media controls (off by default)
Summary: Add a new runtime flag for work on modern media controls (off by default)
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-22 10:57 PDT by Antoine Quint
Modified: 2016-12-08 18:16 PST (History)
11 users (show)

See Also:

Attachments
Patch (20.41 KB, patch)
2016-09-22 11:03 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (20.36 KB, patch)
2016-09-23 00:59 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-09-22 10:57:23 PDT 
Media controls on Apple platforms are going to have significant changes in the coming weeks. In order to land those gradually without negative impacts to usability and stability of existing media controls, we should add a new runtime flag to enable these "modern" media controls. This flag will be turned to be on by default at a later time as the code lands and becomes stable.
Comment 1 Radar WebKit Bug Importer 2016-09-22 10:58:35 PDT 
<rdar://problem/28430201>
Comment 2 Antoine Quint 2016-09-22 11:03:00 PDT 
Created attachment 289578 [details]
Patch
Comment 3 WebKit Commit Bot 2016-09-22 11:06:10 PDT 
Attachment 289578 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2016-09-23 00:50:40 PDT 
Comment on attachment 289578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289578&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests (OOPS!).

Oops!
Comment 5 Antoine Quint 2016-09-23 00:59:36 PDT 
Created attachment 289669 [details]
Patch for landing
Comment 6 Antoine Quint 2016-09-23 02:35:34 PDT 
Comment on attachment 289669 [details]
Patch for landing

https://trac.webkit.org/changeset/206296