Bug 162389 - CachedXSLStylesheet does not need to be updated according Origin/Fetch mode
Summary: CachedXSLStylesheet does not need to be updated according Origin/Fetch mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-22 06:44 PDT by youenn fablet
Modified: 2016-10-06 23:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.91 KB, patch)
2016-09-22 06:48 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (4.92 KB, patch)
2016-10-06 22:45 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-09-22 06:44:25 PDT
No CORS check is done and loading is always same origin.
Comment 1 youenn fablet 2016-09-22 06:48:16 PDT
Created attachment 289558 [details]
Patch
Comment 2 Darin Adler 2016-10-06 20:23:38 PDT
Comment on attachment 289558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289558&action=review

> Source/WebCore/loader/cache/CachedResource.cpp:449
> +    ASSERT(type() != CachedResource::Type::FontResource || type() != CachedResource::Type::SVGFontResource);

This assertion will never fire; the expression will always be true. Please fix this by making this into two separate assertions.
Comment 3 youenn fablet 2016-10-06 22:45:51 PDT
Created attachment 290898 [details]
Patch for landing
Comment 4 youenn fablet 2016-10-06 22:46:30 PDT
Thanks for the review.

> > Source/WebCore/loader/cache/CachedResource.cpp:449
> > +    ASSERT(type() != CachedResource::Type::FontResource || type() != CachedResource::Type::SVGFontResource);
> 
> This assertion will never fire; the expression will always be true. Please
> fix this by making this into two separate assertions.

Right, done.
Comment 5 WebKit Commit Bot 2016-10-06 23:21:08 PDT
Comment on attachment 290898 [details]
Patch for landing

Clearing flags on attachment: 290898

Committed r206902: <http://trac.webkit.org/changeset/206902>
Comment 6 WebKit Commit Bot 2016-10-06 23:21:14 PDT
All reviewed patches have been landed.  Closing bug.