stress/string-joining-long-strings-should-not-crash.js consumes at least 935Mb memory and then crashes on our JSCOnly bots. Let's skip it on memory limited devices.
Created attachment 289555 [details] Patch
Comment on attachment 289555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289555&action=review > JSTests/stress/string-joining-long-strings-should-not-crash.js:2 > -//@ runDefault > +//@largeHeap > +// @runDefault if !$memoryLimited We need this hack, because run-jsc-stress-tests processes all lines started with "//@".
(In reply to comment #0) > stress/string-joining-long-strings-should-not-crash.js consumes > at least 935Mb memory and then crashes on our JSCOnly bots. > Let's skip it on memory limited devices. note: This test consumes 4.3Gb memory on X86_64
Comment on attachment 289555 [details] Patch r=me
Comment on attachment 289555 [details] Patch Clearing flags on attachment: 289555 Committed r206317: <http://trac.webkit.org/changeset/206317>
All reviewed patches have been landed. Closing bug.
Reverted r206317 for reason: This change caused timeouts on El Capitan Release JSC tests Committed r206330: <http://trac.webkit.org/changeset/206330>
*** Bug 162508 has been marked as a duplicate of this bug. ***
(In reply to comment #7) > Reverted r206317 for reason: > > This change caused timeouts on El Capitan Release JSC tests > > Committed r206330: <http://trac.webkit.org/changeset/206330> Sorry for the trouble. It was a typo in my patch, I'll land the fixed patch.
Created attachment 289825 [details] Patch for landing
Comment on attachment 289825 [details] Patch for landing Clearing flags on attachment: 289825 Committed r206374: <http://trac.webkit.org/changeset/206374>