Bug 162383 - [css-grid] ASSERT when sizing tracks with percentages inside calc
Summary: [css-grid] ASSERT when sizing tracks with percentages inside calc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-22 05:39 PDT by Sergio Villar Senin
Modified: 2016-09-23 09:32 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.87 KB, patch)
2016-09-22 05:55 PDT, Sergio Villar Senin 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2016-09-22 05:39:34 PDT 
[css-grid] ASSERT when sizing tracks with percentages inside calc
Comment 1 Sergio Villar Senin 2016-09-22 05:55:51 PDT 
Created attachment 289552 [details]
Patch
Comment 2 Javier Fernandez 2016-09-22 06:07:10 PDT 
Comment on attachment 289552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289552&action=review

the change looks good to me.

> LayoutTests/fast/css-grid-layout/tracks-wider-min-track-breadth-crash.html:5
> +  display: grid;

no need for the display property, since it's included in the "grid" style class provided in grid.css
Comment 3 Sergio Villar Senin 2016-09-23 09:32:06 PDT 
Committed r206310: <http://trac.webkit.org/changeset/206310>