RESOLVED FIXED 162374
Fullscreen controls inoperative in WebKitLegacy web views 
https://bugs.webkit.org/show_bug.cgi?id=162374
Summary Fullscreen controls inoperative in WebKitLegacy web views
Jer Noble
Reported 2016-09-21 21:13:20 PDT
Fullscreen controls inoperative in WebKitLegacy web views
Attachments
Patch (2.50 KB, patch)
2016-09-22 11:32 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-09-21 21:16:50 PDT
<rdar://problem/28339129>
Jer Noble
Comment 2 2016-09-22 11:32:52 PDT
Created attachment 289583 [details] Patch
Jeremy Jones
Comment 3 2016-09-22 11:56:01 PDT
This is fine for a quick fix. But we should have a way to say "everything changed" In WebVideoFillscreenModelMediaElement, there is an event for "all". Either that, or something similar would be better than putting this inline. If we later add new properties, this would help make sure we don't miss this spot.
Jer Noble
Comment 4 2016-09-22 13:43:19 PDT
(In reply to comment #3) > This is fine for a quick fix. But we should have a way to say "everything > changed" > > In WebVideoFillscreenModelMediaElement, there is an event for "all". Either > that, or something similar would be better than putting this inline. If we > later add new properties, this would help make sure we don't miss this spot. I was wondering the same thing about resetMediaState(); it resets the playerController to empty values, even if it still has a playbackSessionModel attached. Maybe in the future, resetMediaState() can retrieve all the cached values from the model if it exists, or set them to defaults if not.
WebKit Commit Bot
Comment 5 2016-09-22 13:57:11 PDT
Comment on attachment 289583 [details] Patch Clearing flags on attachment: 289583 Committed r206272: <http://trac.webkit.org/changeset/206272>
WebKit Commit Bot
Comment 6 2016-09-22 13:57:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.