Bug 162374 - Fullscreen controls inoperative in WebKitLegacy web views
Summary: Fullscreen controls inoperative in WebKitLegacy web views
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-21 21:13 PDT by Jer Noble
Modified: 2016-09-22 13:57 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.50 KB, patch)
2016-09-22 11:32 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-09-21 21:13:20 PDT 
Fullscreen controls inoperative in WebKitLegacy web views
Comment 1 Jer Noble 2016-09-21 21:16:50 PDT 
<rdar://problem/28339129>
Comment 2 Jer Noble 2016-09-22 11:32:52 PDT 
Created attachment 289583 [details]
Patch
Comment 3 Jeremy Jones 2016-09-22 11:56:01 PDT 
This is fine for a quick fix. But we should have a way to say "everything changed"

In WebVideoFillscreenModelMediaElement, there is an event for "all".  Either that, or something similar would be better than putting this inline. If we later add new properties, this would help make sure we don't miss this spot.
Comment 4 Jer Noble 2016-09-22 13:43:19 PDT 
(In reply to comment #3)
> This is fine for a quick fix. But we should have a way to say "everything
> changed"
> 
> In WebVideoFillscreenModelMediaElement, there is an event for "all".  Either
> that, or something similar would be better than putting this inline. If we
> later add new properties, this would help make sure we don't miss this spot.

I was wondering the same thing about resetMediaState(); it resets the playerController to empty values, even if it still has a playbackSessionModel attached. Maybe in the future, resetMediaState() can retrieve all the cached values from the model if it exists, or set them to defaults if not.
Comment 5 WebKit Commit Bot 2016-09-22 13:57:11 PDT 
Comment on attachment 289583 [details]
Patch

Clearing flags on attachment: 289583

Committed r206272: <http://trac.webkit.org/changeset/206272>
Comment 6 WebKit Commit Bot 2016-09-22 13:57:15 PDT 
All reviewed patches have been landed.  Closing bug.