Bug 162356 – Fix serialization of HTML Element attributes

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Fix serialization of Element attributes to align with:
- https://html.spec.whatwg.org/#html-fragment-serialisation-algorithm
- https://html.spec.whatwg.org/#escapingString

In particular, we should not escape '<' and '>'.

Firefox and Chrome both match the specification.

[Chris Dumez]

Only impacts HTML. For XML serialization, we are supposed to escape '<' / '>' in attribute values:
- https://w3c.github.io/DOM-Parsing/#dfn-serializing-an-attribute-value

[Chris Dumez]

Created attachment 289473 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 289473 [details]
Patch

Rejecting attachment 289473 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 289473, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ckout/scm/scm.py", line 77, in run
    decode_output=decode_output)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 443, in run_command
    output = output.decode(self._child_process_encoding())
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xfc in position 146: invalid start byte

Full output: http://webkit-queues.webkit.org/results/2120876

[Chris Dumez]

Comment on attachment 289473 [details]
Patch

Clearing flags on attachment: 289473

Committed r206240: <http://trac.webkit.org/changeset/206240>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.