Bug 162328 - Fix enumeration of properties cross origin
Summary: Fix enumeration of properties cross origin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on: 162311
Blocks:
  Show dependency tree / graph
 
Reported: 2016-09-20 18:46 PDT by Chris Dumez
Modified: 2016-09-21 13:49 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.04 KB, patch)
2016-09-20 18:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-09-20 18:46:32 PDT 
All cross origin properties for Window / Location are supposed to be not enumerable:
- https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)

Therefore, there should be no properties to iterate on for cross origin Window / Location objects.

W3C test:
- http://w3c-test.org/html/browsers/origin/cross-origin-objects/cross-origin-objects.html ([[Enumerate]] subtest)
Comment 1 Chris Dumez 2016-09-20 18:51:09 PDT 
Created attachment 289423 [details]
Patch
Comment 2 Alex Christensen 2016-09-21 12:52:57 PDT 
Comment on attachment 289423 [details]
Patch

Are both of the changes covered by the one test?
Comment 3 Chris Dumez 2016-09-21 12:53:58 PDT 
(In reply to comment #2)
> Comment on attachment 289423 [details]
> Patch
> 
> Are both of the changes covered by the one test?

Yes, this test iterates both on Window and Location.
Comment 4 Chris Dumez 2016-09-21 13:49:15 PDT 
Comment on attachment 289423 [details]
Patch

Clearing flags on attachment: 289423

Committed r206233: <http://trac.webkit.org/changeset/206233>
Comment 5 Chris Dumez 2016-09-21 13:49:21 PDT 
All reviewed patches have been landed.  Closing bug.