Bug 162327 - REGRESSION(r205692): Minified builds have broken inspector
Summary: REGRESSION(r205692): Minified builds have broken inspector
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2016-09-20 18:01 PDT by Joseph Pecoraro
Modified: 2016-09-20 18:05 PDT (History)
11 users (show)

See Also:

[PATCH] Proposed Fix (2.17 KB, patch)
2016-09-20 18:02 PDT, Joseph Pecoraro
mattbaker: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-20 18:01:15 PDT
Minified builds have broken inspector

Seems the JavaScriptCore cssmin.py was older then the WebInspector one we dropped.
The jsmin.py files were equivalent.

Bring back the proper cssmin.
Comment 1 Joseph Pecoraro 2016-09-20 18:01:23 PDT
Comment 2 Joseph Pecoraro 2016-09-20 18:02:45 PDT
Created attachment 289417 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2016-09-20 18:04:48 PDT
Attachment 289417 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/Scripts/cssmin.py:33:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Joseph Pecoraro 2016-09-20 18:05:56 PDT