Bug 162325 - enable remote_api (for debugging) in flakiness dashboard app
Summary: enable remote_api (for debugging) in flakiness dashboard app
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-20 16:41 PDT by Aakash Jain
Modified: 2016-09-20 17:23 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (970 bytes, patch)
2016-09-20 16:45 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-09-20 16:41:49 PDT
remote_api is very useful for debugging any issues in the app. QueueStatusServer already has it enabled long back (since https://trac.webkit.org/changeset/70028).
Comment 1 Aakash Jain 2016-09-20 16:45:28 PDT
Created attachment 289408 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2016-09-20 16:48:58 PDT
Comment on attachment 289408 [details]
Proposed patch

Fine to have this for consistency, although the security aspect of exposing this is questionable. Probably best to disable once you are done debugging, or to have it password protected.
Comment 3 WebKit Commit Bot 2016-09-20 17:23:16 PDT
Comment on attachment 289408 [details]
Proposed patch

Clearing flags on attachment: 289408

Committed r206187: <http://trac.webkit.org/changeset/206187>
Comment 4 WebKit Commit Bot 2016-09-20 17:23:19 PDT
All reviewed patches have been landed.  Closing bug.