Bug 162324 - FTL needs to reserve callee stack space in bytes
Summary: FTL needs to reserve callee stack space in bytes
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
Depends on:
Reported: 2016-09-20 16:40 PDT by Michael Saboff
Modified: 2016-09-21 09:28 PDT (History)
4 users (show)

See Also:

Patch (8.29 KB, patch)
2016-09-20 17:45 PDT, Michael Saboff
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2016-09-20 16:40:49 PDT
The FTL code to compile outgoing calls uses the B3 function, requestCallArgAreaSize(), to assure there is enough stack space to make the call.  In one instance the call is made with a argument in bytes, while the other two instances use count of JSValue sized objects.  Reading the code in B3 and Air shows that the value should be in bytes.  Therefore those two instances are wrong.
Comment 1 Michael Saboff 2016-09-20 17:45:46 PDT
Created attachment 289414 [details]
Comment 2 Geoffrey Garen 2016-09-20 20:20:19 PDT
Comment on attachment 289414 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=289414&action=review


> Source/JavaScriptCore/ChangeLog:14
> +        No new tests as this doesn't surface as an issue when arguments are pass on the stack.

Comment 3 Michael Saboff 2016-09-21 09:28:26 PDT
Committed r206212: <http://trac.webkit.org/changeset/206212>