Bug 162323 - Web Inspector: Reload unexpectedly switches to Storage Tab
Summary: Web Inspector: Reload unexpectedly switches to Storage Tab
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-20 16:37 PDT by Joseph Pecoraro
Modified: 2016-09-20 19:48 PDT (History)
7 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (5.92 KB, patch)
2016-09-20 16:40 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-09-20 16:37:24 PDT
Summary:
Reload unexpectedly switches to Storage Tab

Test:
<script>
localStorage.x = 1;
</script>

Steps to Reproduce:
1. Start a web server for the simple test page (python -m SimpleHTTPServer)
2. Launch Safari and open test page (http://0.0.0.0:8000)
3. Select Storage Tab
4. Select LocalStorage
5. Select Console Tab
6. Reload
  => Storage Tab suddenly becomes foreground

Notes:
- The StorageTab is forcing itself forward because when removing tree elements from the StorageNavigationSidebar one by one we re-select the next available. Selecting is what forces the tab to the foreground. This is unnecessary since they will all be removed anyways.
- After all is said and done, selecting the StorageTab should restore properly (re-select the appropriate LocalStorage, etc) and it isn't.
Comment 1 Joseph Pecoraro 2016-09-20 16:37:33 PDT
<rdar://problem/28393954>
Comment 2 Joseph Pecoraro 2016-09-20 16:40:39 PDT
Created attachment 289407 [details]
[PATCH] Proposed Fix
Comment 3 Matt Baker 2016-09-20 19:27:28 PDT
Comment on attachment 289407 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2016-09-20 19:48:30 PDT
Comment on attachment 289407 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 289407

Committed r206195: <http://trac.webkit.org/changeset/206195>
Comment 5 WebKit Commit Bot 2016-09-20 19:48:34 PDT
All reviewed patches have been landed.  Closing bug.