Bug 162313 - Require WTFMove for String::adopt
Summary: Require WTFMove for String::adopt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-20 13:33 PDT by Alex Christensen
Modified: 2016-10-17 18:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.27 KB, patch)
2016-09-20 13:34 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (17.30 KB, patch)
2016-09-20 18:24 PDT, Alex Christensen 		ysuzuki: review+
Details | Formatted Diff | Diff
Build fix for WinCairo (1.11 KB, patch)
2016-09-22 11:07 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-20 13:33:09 PDT 
Require WTFMove for String::adopt
Comment 1 Alex Christensen 2016-09-20 13:34:13 PDT 
Created attachment 289394 [details]
Patch
Comment 2 Yusuke Suzuki 2016-09-20 14:18:36 PDT 
It seems that Source/WebCore/platform/text/LocaleICU.cpp also has String::adopt.
Comment 3 Alex Christensen 2016-09-20 18:24:13 PDT 
Created attachment 289420 [details]
Patch
Comment 4 Yusuke Suzuki 2016-09-20 19:36:14 PDT 
Comment on attachment 289420 [details]
Patch

r=me
Comment 5 Alex Christensen 2016-09-20 20:13:27 PDT 
https://trac.webkit.org/changeset/206196
Comment 6 Don Olmstead 2016-09-22 11:07:14 PDT 
This revision breaks the WinCairo build
Comment 7 Don Olmstead 2016-09-22 11:07:40 PDT 
Created attachment 289580 [details]
Build fix for WinCairo
Comment 8 WebKit Commit Bot 2016-09-22 11:45:56 PDT 
Comment on attachment 289580 [details]
Build fix for WinCairo

Clearing flags on attachment: 289580

Committed r206265: <http://trac.webkit.org/changeset/206265>