Bug 162305 - REGRESSION(r206133): LayoutTest inspector/css/manager-preferredInspectorStyleSheetForFrame.html is a flaky failure
Summary: REGRESSION(r206133): LayoutTest inspector/css/manager-preferredInspectorStyle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-20 10:52 PDT by Ryan Haddad
Modified: 2017-01-11 21:57 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.05 KB, patch)
2017-01-11 16:23 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-09-20 10:52:08 PDT 
LayoutTest inspector/css/manager-preferredInspectorStyleSheetForFrame.html is a flaky failure

This test has started frequently failing after http://trac.webkit.org/changeset/206133

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcss%2Fmanager-preferredInspectorStyleSheetForFrame.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/css/manager-preferredInspectorStyleSheetForFrame-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/css/manager-preferredInspectorStyleSheetForFrame-actual.txt
@@ -20,12 +20,12 @@
 PASS: StyleSheet.isInspectorStyleSheet() should be true.
 
 -- Running test case: CreateSubFrameInspectorStyleSheet
+PASS: Added StyleSheet origin should be 'inspector'.
+PASS: StyleSheet.isInspectorStyleSheet() should be true.
+PASS: Added StyleSheet frame should be a child frame.
 PASS: Should be two stylesheets.
 PASS: StyleSheet origin should be 'inspector'.
 PASS: StyleSheet.isInspectorStyleSheet() should be true.
-PASS: Added StyleSheet origin should be 'inspector'.
-PASS: StyleSheet.isInspectorStyleSheet() should be true.
-PASS: Added StyleSheet frame should be a child frame.
 
 -- Running test case: AnotherSubFrameRequestDoesNothing
 PASS: Should be two stylesheets.
Comment 2 Radar WebKit Bug Importer 2016-09-20 10:52:51 PDT 
<rdar://problem/28389364>
Comment 3 Ryan Haddad 2016-09-21 13:45:48 PDT 
Marked test as flaky in https://trac.webkit.org/r206232
Comment 4 Alexey Proskuryakov 2016-09-25 12:09:55 PDT 
Is there some reason why this change hasn't been rolled out?
Comment 5 Alexey Proskuryakov 2016-11-05 10:12:07 PDT 
Seriously, a test change that broke the test, and we are keeping it in the tree?
Comment 6 Joseph Pecoraro 2017-01-11 16:16:30 PST 
I'll take a look. Reverting the original change, scoped to just this test, seems fine to me. I don't find the new awaitEvent clearer in these tests at all anyways, and they add an extra turn of the runloop which (in cases like we see in this test) may cause flakiness.
Comment 7 Joseph Pecoraro 2017-01-11 16:23:04 PST 
Created attachment 298627 [details]
[PATCH] Proposed Fix

Before this change this test failed 30 out of 100 times when run with --iterations=100.
After this change I saw 0 failures.
Comment 8 WebKit Commit Bot 2017-01-11 21:57:50 PST 
Comment on attachment 298627 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 298627

Committed r210622: <http://trac.webkit.org/changeset/210622>
Comment 9 WebKit Commit Bot 2017-01-11 21:57:53 PST 
All reviewed patches have been landed.  Closing bug.