RESOLVED FIXED 162266
[Win] Null pointer crash under WebCore::CACFLayerTreeHost::create(). 
https://bugs.webkit.org/show_bug.cgi?id=162266
Summary [Win] Null pointer crash under WebCore::CACFLayerTreeHost::create().
Per Arne Vollan
Reported 2016-09-20 05:39:55 PDT
Stack from crash dump: WebKit!WebCore::CACFLayerTreeHost::initialize+0x6 WebKit!WebCore::CACFLayerTreeHost::create+0x6e WebKit!WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable+0xfb WebKit!WebPreferences::acceleratedCompositingEnabled+0x2a WebKit!WebView::notifyPreferencesChanged+0xddd WebKit!WebView::onNotify+0xb5 WebKit!WebNotificationCenter::postNotificationInternal+0x10f WebKit!WebNotificationCenter::postNotificationName+0x3f WebKit!WebPreferences::postPreferencesChangesNotification+0x31 WebKit!WebView::initWithFrame+0x763
Attachments
Patch (1.24 KB, patch)
2016-09-20 05:43 PDT, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2016-09-20 05:43:25 PDT
Created attachment 289341 [details] Patch
Per Arne Vollan
Comment 2 2016-09-20 05:44:19 PDT
rdar://problem/28345073
Brent Fulgham
Comment 3 2016-09-20 06:54:39 PDT
Comment on attachment 289341 [details] Patch R=me
Simon Fraser (smfr)
Comment 4 2016-09-20 08:28:13 PDT
Comment on attachment 289341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289341&action=review > Source/WebCore/ChangeLog:4 > + [Win] Null pointer crash under WebCore::CACFLayerTreeHost::create(). > + https://bugs.webkit.org/show_bug.cgi?id=162266 The radar number should be here too.
Brent Fulgham
Comment 5 2016-09-20 09:12:42 PDT
Comment on attachment 289341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289341&action=review > Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:121 > + return nullptr; Thinking about this more, I wonder if we should add a WTFLog here to document that we couldn't get a valid CACFLayerTreeHost. This is unusual, and would be a key clue in diagnosing weird behavior if we could see it in console output.
Per Arne Vollan
Comment 6 2016-09-21 13:57:30 PDT
(In reply to comment #5) > Comment on attachment 289341 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289341&action=review > > > Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:121 > > + return nullptr; > > Thinking about this more, I wonder if we should add a WTFLog here to > document that we couldn't get a valid CACFLayerTreeHost. This is unusual, > and would be a key clue in diagnosing weird behavior if we could see it in > console output. Thanks for reviewing! I will add the radar number and log statement before landing.
Per Arne Vollan
Comment 7 2016-09-21 13:59:26 PDT
Committed r206234: <https://trac.webkit.org/changeset/206234>
Note You need to log in before you can comment on or make changes to this bug.