Stack from crash dump: WebKit!WebCore::CACFLayerTreeHost::initialize+0x6 WebKit!WebCore::CACFLayerTreeHost::create+0x6e WebKit!WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable+0xfb WebKit!WebPreferences::acceleratedCompositingEnabled+0x2a WebKit!WebView::notifyPreferencesChanged+0xddd WebKit!WebView::onNotify+0xb5 WebKit!WebNotificationCenter::postNotificationInternal+0x10f WebKit!WebNotificationCenter::postNotificationName+0x3f WebKit!WebPreferences::postPreferencesChangesNotification+0x31 WebKit!WebView::initWithFrame+0x763
Created attachment 289341 [details] Patch
rdar://problem/28345073
Comment on attachment 289341 [details] Patch R=me
Comment on attachment 289341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289341&action=review > Source/WebCore/ChangeLog:4 > + [Win] Null pointer crash under WebCore::CACFLayerTreeHost::create(). > + https://bugs.webkit.org/show_bug.cgi?id=162266 The radar number should be here too.
Comment on attachment 289341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289341&action=review > Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:121 > + return nullptr; Thinking about this more, I wonder if we should add a WTFLog here to document that we couldn't get a valid CACFLayerTreeHost. This is unusual, and would be a key clue in diagnosing weird behavior if we could see it in console output.
(In reply to comment #5) > Comment on attachment 289341 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289341&action=review > > > Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:121 > > + return nullptr; > > Thinking about this more, I wonder if we should add a WTFLog here to > document that we couldn't get a valid CACFLayerTreeHost. This is unusual, > and would be a key clue in diagnosing weird behavior if we could see it in > console output. Thanks for reviewing! I will add the radar number and log statement before landing.
Committed r206234: <https://trac.webkit.org/changeset/206234>