If the CoreText headers already has defined 'kCTFontTableOptionNoOptions', I get the following compile error: Source\WebCore\platform\spi\win\CoreTextSPIWin.h(44): error C2365: 'kCTFontTableOptionNoOptions': redefinition; previous definition was 'enumerator' (compiling source file Source\WebCore\platform\graphics\ca\PlatformCALayer.cpp) include\CoreText/CTFont.h(1285): note: see declaration of 'kCTFontTableOptionNoOptions' (compiling source file Source\WebCore\platform\graphics\ca\PlatformCALayer.cpp)
Created attachment 289339 [details] Patch
Comment on attachment 289339 [details] Patch This doesn't seem to work. Usually the compiler is happy if we typedef in multiple places as long as they are the same. Maybe expanding the CF_OPTIONS macro manually would work.
Comment on attachment 289339 [details] Patch Usually we don't have a problem as long as the typdef's match. It might be that expanding the CF_OPTIONS macro manually would make the compiler happy? At any rate, this code change doesn't seem to work on the build machines.
This error doesn't make any sense. What does "previous definition was 'enumerator' mean? Where is 'enumerator'? I don't see the symbol defined twice inside WebKit sources...
Created attachment 290190 [details] Patch
Thanks for reviewing :) The symbol is not defined twice in WebKit, but when compiling with some older SDK versions, the symbol is included when including <CoreText/CoreText.h>.
Comment on attachment 290190 [details] Patch Clearing flags on attachment: 290190 Committed r206584: <http://trac.webkit.org/changeset/206584>
All reviewed patches have been landed. Closing bug.