Bug 162259 - Adopt MRMediaRemoteSetParentApplication.
Summary: Adopt MRMediaRemoteSetParentApplication.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-09-19 23:59 PDT by Jer Noble
Modified: 2016-10-31 09:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.48 KB, patch)
2016-09-20 00:38 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (11.00 KB, patch)
2016-09-20 09:20 PDT, Jer Noble 		andersca: review+
Details | Formatted Diff | Diff
Patch for landing (12.26 KB, patch)
2016-09-20 17:02 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-09-19 23:59:07 PDT 
Adopt MRMediaRemoteSetParentApplication.
Comment 1 Jer Noble 2016-09-20 00:37:18 PDT 
<rdar://problem/28376161>
Comment 2 Jer Noble 2016-09-20 00:38:26 PDT 
Created attachment 289334 [details]
Patch
Comment 3 Sam Weinig 2016-09-20 01:48:22 PDT 
Comment on attachment 289334 [details]
Patch

What is the ramification of passing a bad source application identifier here? If this is new SPI, should we pass the sourceApplicationAuditData instead, since that is verifiable?
Comment 4 Jer Noble 2016-09-20 09:20:28 PDT 
Created attachment 289357 [details]
Patch
Comment 5 Anders Carlsson 2016-09-20 10:55:45 PDT 
Comment on attachment 289357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289357&action=review

> Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:176
> +    if (MRMediaRemoteSetParentApplication && !parentApplication.isEmpty())

Should this be canLoad_MRMediaRemoteSetParentApplication?
Comment 6 Jer Noble 2016-09-20 16:39:22 PDT 
(In reply to comment #5)
> Comment on attachment 289357 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=289357&action=review
> 
> > Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm:176
> > +    if (MRMediaRemoteSetParentApplication && !parentApplication.isEmpty())
> 
> Should this be canLoad_MRMediaRemoteSetParentApplication?

Yep!
Comment 7 Jer Noble 2016-09-20 17:02:21 PDT 
Created attachment 289411 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2016-09-20 18:12:32 PDT 
Comment on attachment 289411 [details]
Patch for landing

Clearing flags on attachment: 289411

Committed r206193: <http://trac.webkit.org/changeset/206193>