Bug 162258 – CachedResourceRequest should store a SecurityOrigin

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

That way, it will be able to pass it to CachedResource at construction time.
Currently it is based on Origin header or Document origin.
In the first case, we lose some information like universal access.

[youenn fablet]

Created attachment 289332 [details]
Patch

[youenn fablet]

Created attachment 289337 [details]
Patch

[youenn fablet]

Created attachment 289338 [details]
Patch

[Sam Weinig]

Comment on attachment 289338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289338&action=review

> Source/WebCore/loader/cache/CachedResourceRequest.h:81
> +    RefPtr<SecurityOrigin> m_origin;

In what scenarios can this be null (other than when we release it).  Can we require setting the origin in the constructor?  Also, should this really be a SecurityOrigin, or would a SecuirtyOriginData work (we need to establish clear rules on this, cc. andersca)?

[youenn fablet]

(In reply to comment #4)
> Comment on attachment 289338 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=289338&action=review
> 
> > Source/WebCore/loader/cache/CachedResourceRequest.h:81
> > +    RefPtr<SecurityOrigin> m_origin;
> 
> In what scenarios can this be null (other than when we release it).  Can we
> require setting the origin in the constructor?

It is null when fetching main resources during navigation.
We could require setting it within the constructor but most of the time it will be the context securityOrigin.

In the fetch spec, the origin is either an origin or set to the special "client" value, which we represents as a null RefPtr. In both spec and implementation, this is the default value.

> Also, should this really be
> a SecurityOrigin, or would a SecuirtyOriginData work (we need to establish
> clear rules on this, cc. andersca)?

Looking at SecurityOriginData, it seems it is a tuple (protocol, host, port)
As illustrated by the modified test, it is important to keep information such as m_universalAccess which AIUI SecurityOriginData is not aware.

[youenn fablet]

Created attachment 289451 [details]
Rebasing after bug 162260

[WebKit Commit Bot]

Comment on attachment 289451 [details]
Rebasing after bug 162260

Clearing flags on attachment: 289451

Committed r206255: <http://trac.webkit.org/changeset/206255>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.