RESOLVED FIXED Bug 162253
[JSC] Add `typeof value === "symbol"` handling to bytecode compiler 
https://bugs.webkit.org/show_bug.cgi?id=162253
Summary [JSC] Add `typeof value === "symbol"` handling to bytecode compiler
Yusuke Suzuki
Reported 2016-09-19 21:41:27 PDT
We can easily implement it by using is_cell_with_type.
Attachments
Patch (4.44 KB, patch)
2016-09-19 21:50 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-09-19 21:47:48 PDT
Benefit is super tiny, but it is consistent to the current implementation that have the similar path for "string" case.
Yusuke Suzuki
Comment 2 2016-09-19 21:48:09 PDT
baseline patched is-symbol 1.5291+-0.0149 ^ 1.4763+-0.0160 ^ definitely 1.0358x faster is-symbol-mixed 4.7242+-0.1301 4.5916+-0.1242 might be 1.0289x faster
Yusuke Suzuki
Comment 3 2016-09-19 21:50:17 PDT
Created attachment 289310 [details] Patch
Yusuke Suzuki
Comment 4 2016-09-20 08:24:40 PDT
Comment on attachment 289310 [details] Patch Thanks!
WebKit Commit Bot
Comment 5 2016-09-20 08:47:56 PDT
Comment on attachment 289310 [details] Patch Clearing flags on attachment: 289310 Committed r206147: <http://trac.webkit.org/changeset/206147>
WebKit Commit Bot
Comment 6 2016-09-20 08:48:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.