Bug 162251 - Align URLParser with web platform tests when parsing non-special relative URLs ending in AuthorityOrHost state
Summary: Align URLParser with web platform tests when parsing non-special relative URL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-19 20:32 PDT by Alex Christensen
Modified: 2016-09-20 11:48 PDT (History)
0 users

See Also:

Attachments
Patch (16.28 KB, patch)
2016-09-19 20:35 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-09-19 20:32:58 PDT 
Align URLParser with web platform tests when parsing non-special relative URLs ending in AuthorityOrHost state
Comment 1 Alex Christensen 2016-09-19 20:35:28 PDT 
Created attachment 289305 [details]
Patch
Comment 2 Tim Horton 2016-09-20 11:10:21 PDT 
Comment on attachment 289305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289305&action=review

> Source/WebCore/ChangeLog:12
> +        Fix non-special URLs that end after scheme:// with no authority.

"Fix" is way too vague.

> Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:541
> +    // This matches the spec and web platform tests, but not Chrome, Firefox, or URL::parse.

!

Is this a case where you think the spec is wrong and will try to get it changed, or what?
Comment 3 Alex Christensen 2016-09-20 11:37:41 PDT 
(In reply to comment #2)
> > Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:541
> > +    // This matches the spec and web platform tests, but not Chrome, Firefox, or URL::parse.
> 
> !
> 
> Is this a case where you think the spec is wrong and will try to get it
> changed, or what?
I think the spec might be right and everybody needs to change.  We'll see.
Comment 4 Alex Christensen 2016-09-20 11:48:59 PDT 
https://trac.webkit.org/changeset/206162