Bug 162250 – REGRESSION (r204552): Athlete search on Strava gives bad rendering.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

1. Log into Strava
2. Be on your feed page: https://www.strava.com/dashboard
3. Click the magnifying glass
4. Start typing

[zalan]

rdar://problem/28156433

[zalan]

Created attachment 289308 [details]
Patch

[Build Bot]

Comment on attachment 289308 [details]
Patch

Attachment 289308 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2109844

New failing tests:
compositing/layer-creation/overlap-transformed-layer.html
compositing/layer-creation/overlap-child-layer.html
compositing/layer-creation/fixed-position-under-transform.html
imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html
imported/blink/compositing/child-transform-layer-rounding.html

[Build Bot]

Created attachment 289311 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289308 [details]
Patch

Attachment 289308 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2109877

New failing tests:
compositing/layer-creation/overlap-transformed-layer.html
compositing/layer-creation/overlap-child-layer.html
compositing/layer-creation/fixed-position-under-transform.html
imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html
imported/blink/compositing/child-transform-layer-rounding.html

[Build Bot]

Created attachment 289312 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289308 [details]
Patch

Attachment 289308 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2109871

New failing tests:
compositing/layer-creation/overlap-transformed-layer.html
compositing/layer-creation/overlap-child-layer.html
compositing/layer-creation/fixed-position-under-transform.html
imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html
imported/blink/compositing/child-transform-layer-rounding.html

[Build Bot]

Created attachment 289314 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 289308 [details]
Patch

Attachment 289308 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2109879

New failing tests:
compositing/layer-creation/overlap-transformed-layer.html
compositing/layer-creation/overlap-child-layer.html
compositing/layer-creation/fixed-position-under-transform.html
imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html
imported/blink/compositing/child-transform-layer-rounding.html

[Build Bot]

Created attachment 289317 [details]
Archive of layout-test-results from ews124 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.6

[zalan]

Created attachment 289354 [details]
Patch

[zalan]

Created attachment 289400 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 289400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289400&action=review

> Source/WebCore/platform/graphics/LayoutRect.h:134
> +        float maxX = location.x() + size.width();
> +        float maxY = location.y() + size.height();

Use FloatRect::maxX()/maxY().

> Source/WebCore/platform/graphics/LayoutRect.h:150
> +    void checkedUnite(const LayoutRect&);

I think this should return a bool saying if it bailed.

[zalan]

Created attachment 289405 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 289405 [details]
Patch

Clearing flags on attachment: 289405

Committed r206188: <http://trac.webkit.org/changeset/206188>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.