Bug 162249 – Add Sierra bots to buildbot and dashboard

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dean Johnson]

We should bring up Sierra bots and add them to the dashboard.

[Dean Johnson]

Created attachment 289303 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 289303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289303&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:101
> +                      "slavenames": ["bot439", "bot698"]

These bot numbers confuse me.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:116
> +                      "slavenames": ["bot443", "bot699"]

So do these.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:130
> +                      "slavenames": ["bot998"]

And this.

[Csaba Osztrogonác]

Please update master cfg unittests.

[Csaba Osztrogonác]

And I can't see JSC tester bots in the list.

[Alexey Proskuryakov]

> And I can't see JSC tester bots in the list.

That's intentional - JSC doesn't need to be tested on each macOS version. We may move the bots later.

[Alexey Proskuryakov]

Comment on attachment 289303 [details]
Patch

r-, since I believe bot998 needs to be fixed

[Dean Johnson]

Created attachment 289399 [details]
Patch

[Dean Johnson]

Thanks for the comments and catches on bot names as well as unit tests!

New patch is posted. Changes from the previous patch are as follows:

- bot998 -> bot600 (assigned hostname)
- Added expected Sierra steps in mastercfg_unittest.py

[Alexey Proskuryakov]

Comment on attachment 289399 [details]
Patch

The new testers also need to be added to EWS configuration.

[WebKit Commit Bot]

Comment on attachment 289399 [details]
Patch

Clearing flags on attachment: 289399

Committed r206178: <http://trac.webkit.org/changeset/206178>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

Reverted r206178 for reason:

This change caused buildbot config issues.

Committed r206180: <http://trac.webkit.org/changeset/206180>

[Dean Johnson]

The issue was the passwords.json was not updated on the master, and thus caused the buildmaster to get a KeyError when trying to read passwords for the newly added slaves. 

It's now been fixed and Ryan said he'll pull the patch back in.

[Ryan Haddad]

Reverted r206180 for reason:

Roll r206178 back in as the necessary changes have been made on the build master.

Committed r206184: <http://trac.webkit.org/changeset/206184>

[Csaba Osztrogonác]

(In reply to comment #5)
> > And I can't see JSC tester bots in the list.
> 
> That's intentional - JSC doesn't need to be tested on each macOS version. We
> may move the bots later.

I thought it was a mistake. It's strange that you don't test JSC on the recent
macOS, but only on the older versions. But it's your decision, I don't care. :)

[Alexey Proskuryakov]

Dean, has this been resolved? I see that the bots are on the dashboard.

[Dean Johnson]

Yes, sorry for not updating it.

And Csaba, we do plan on upgrading the JSC testers from El Cap -> Sierra, just not initially. :)