We should bring up Sierra bots and add them to the dashboard.
Created attachment 289303 [details] Patch
Comment on attachment 289303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289303&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:101 > + "slavenames": ["bot439", "bot698"] These bot numbers confuse me. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:116 > + "slavenames": ["bot443", "bot699"] So do these. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:130 > + "slavenames": ["bot998"] And this.
Please update master cfg unittests.
And I can't see JSC tester bots in the list.
> And I can't see JSC tester bots in the list. That's intentional - JSC doesn't need to be tested on each macOS version. We may move the bots later.
Comment on attachment 289303 [details] Patch r-, since I believe bot998 needs to be fixed
Created attachment 289399 [details] Patch
Thanks for the comments and catches on bot names as well as unit tests! New patch is posted. Changes from the previous patch are as follows: - bot998 -> bot600 (assigned hostname) - Added expected Sierra steps in mastercfg_unittest.py
Comment on attachment 289399 [details] Patch The new testers also need to be added to EWS configuration.
Comment on attachment 289399 [details] Patch Clearing flags on attachment: 289399 Committed r206178: <http://trac.webkit.org/changeset/206178>
All reviewed patches have been landed. Closing bug.
Reverted r206178 for reason: This change caused buildbot config issues. Committed r206180: <http://trac.webkit.org/changeset/206180>
The issue was the passwords.json was not updated on the master, and thus caused the buildmaster to get a KeyError when trying to read passwords for the newly added slaves. It's now been fixed and Ryan said he'll pull the patch back in.
Reverted r206180 for reason: Roll r206178 back in as the necessary changes have been made on the build master. Committed r206184: <http://trac.webkit.org/changeset/206184>
(In reply to comment #5) > > And I can't see JSC tester bots in the list. > > That's intentional - JSC doesn't need to be tested on each macOS version. We > may move the bots later. I thought it was a mistake. It's strange that you don't test JSC on the recent macOS, but only on the older versions. But it's your decision, I don't care. :)
Dean, has this been resolved? I see that the bots are on the dashboard.
Yes, sorry for not updating it. And Csaba, we do plan on upgrading the JSC testers from El Cap -> Sierra, just not initially. :)