Bug 162246 – [WinCairo] Not building since 206044

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Christopher Reid]

CookieJarCurl.cpp was failing to compile due to some string builder changes. 

Also JSWebGLRenderingContextCustom.cpp was failing to link due to this error:
WebCore.lib(JSWebGLRenderingContextCustom.obj) : error LNK2001: unresolved external symbol "private: void * __cdecl JSC
::Heap::allocateObjectOfType<class JSC::Structure>(unsigned __int64)" (??$allocateObjectOfType@VStructure@JSC@@@Heap@JS
C@@AEAAPEAX_K@Z)

[Christopher Reid]

Created attachment 289288 [details]
Patch

[WebKit Commit Bot]

Attachment 289288 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Christopher Reid]

Created attachment 289290 [details]
Patch

[Alex Christensen]

Comment on attachment 289290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289290&action=review

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:226
> -    cookieStr.append(cookieName + "\t");
> +    cookieStr.append(String(domain + "\t"));

What's this?  If this is necessary, we should call append twice instead of appending the result of allocating a string, copying two strings, then appending it.

[Christopher Reid]

Created attachment 289389 [details]
New patch to remove temporary strings as suggested

[Christopher Reid]

For reference the error we're seeing with CookieJarCurl is:
Source\WebCore\platform\network\curl\CookieJarCurl.cpp(226): error C2668: 'WTF::StringBuilder::append': amb
iguous call to overloaded function

The ambiguous calls are WTF::StringBuilder::append(const WTF::AtomicString&) and WTF::StringBuilder::append(const WTF::String&)

[WebKit Commit Bot]

Comment on attachment 289389 [details]
New patch to remove temporary strings as suggested

Clearing flags on attachment: 289389

Committed r206163: <http://trac.webkit.org/changeset/206163>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.