Bug 162243 – Suppress JavaScript prompts early on in certain cases

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Suppress JavaScript prompts early on in certain cases

[Anders Carlsson]

Created attachment 289271 [details]
Patch

[Geoffrey Garen]

Comment on attachment 289271 [details]
Patch

What about WK1?

Are we sure that window.open() on a timer can't interrupt a navigation in a non-window.open document?

Need some export action:

  "WebCore::FrameLoaderStateMachine::isDisplayingInitialEmptyDocument() const", referenced from:
      WebKit::shouldSuppressJavaScriptDialogs(WebCore::Frame&) in WebChromeClient.o

r=me

[Anders Carlsson]

Created attachment 289278 [details]
Patch

[Geoffrey Garen]

Comment on attachment 289278 [details]
Patch

r=me

[Chris Dumez]

Comment on attachment 289278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289278&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:382
> +static bool shouldSuppressJavaScriptDialogs(Frame& frame)

Why are we doing this in WebKit2 and not on DOMWindow in WebCore? Note that we already have page->arePromptsAllowed() for similar purposes.

[Anders Carlsson]

(In reply to comment #5)
> Comment on attachment 289278 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=289278&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:382
> > +static bool shouldSuppressJavaScriptDialogs(Frame& frame)
> 
> Why are we doing this in WebKit2 and not on DOMWindow in WebCore? Note that
> we already have page->arePromptsAllowed() for similar purposes.

It's a targeted fix for a WK2 specific problem.

[Chris Dumez]

Comment on attachment 289278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289278&action=review

>> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:382
>> +static bool shouldSuppressJavaScriptDialogs(Frame& frame)
> 
> Why are we doing this in WebKit2 and not on DOMWindow in WebCore? Note that we already have page->arePromptsAllowed() for similar purposes.

See ForbidPromptsScope in FrameLoader.

[Anders Carlsson]

(In reply to comment #7)
> Comment on attachment 289278 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=289278&action=review
> 
> >> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:382
> >> +static bool shouldSuppressJavaScriptDialogs(Frame& frame)
> > 
> > Why are we doing this in WebKit2 and not on DOMWindow in WebCore? Note that we already have page->arePromptsAllowed() for similar purposes.
> 
> See ForbidPromptsScope in FrameLoader.

Using ForbidPromptsScope in this case isn't possible (it certainly won't make things easier).

[Chris Dumez]

(In reply to comment #8)
> (In reply to comment #7)
> > Comment on attachment 289278 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=289278&action=review
> > 
> > >> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:382
> > >> +static bool shouldSuppressJavaScriptDialogs(Frame& frame)
> > > 
> > > Why are we doing this in WebKit2 and not on DOMWindow in WebCore? Note that we already have page->arePromptsAllowed() for similar purposes.
> > 
> > See ForbidPromptsScope in FrameLoader.
> 
> Using ForbidPromptsScope in this case isn't possible (it certainly won't
> make things easier).

Ok, just making sure this was intentional.

[Anders Carlsson]

Committed r206132: <http://trac.webkit.org/changeset/206132>

[Alex Christensen]

Should this still be r?