WinCairo is currently manually appending the sources and libraries for Cairo. It should be using find_package(CAIRO) instead.
Created attachment 289281 [details] Add find_package cairo
Created attachment 289283 [details] Add find_package cairo
Created attachment 289285 [details] With correct line endings
Comment on attachment 289285 [details] With correct line endings Looks good. Let's get alex to look at it for final approval.
Attachment 289285 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 289285 [details] With correct line endings Seems legit. If it breaks the WinCairo bot, we'll roll it out.
Comment on attachment 289285 [details] With correct line endings Rejecting attachment 289285 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 289285, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2108698
Created attachment 289292 [details] Fix style issues
Comment on attachment 289292 [details] Fix style issues Clearing flags on attachment: 289292 Committed r206153: <http://trac.webkit.org/changeset/206153>
All reviewed patches have been landed. Closing bug.